From 96195d2c83d93c7bea0e8ff5767427b0d40e098d Mon Sep 17 00:00:00 2001 From: Mitchell Hanberg Date: Sat, 6 Sep 2025 20:21:35 -0400 Subject: [PATCH 1/3] ci: update testing matrix This tests the engine related code on a bunch of different versions, as its the code being run in the hostile user environment. The Expert tests are only run in the versions for which we build the release. --- .github/matrix.json | 122 +++++++++++++++++++++++++++++++++++++++++++- matrix.exs | 28 ++++------ 2 files changed, 131 insertions(+), 19 deletions(-) diff --git a/.github/matrix.json b/.github/matrix.json index 9b5b61bb..8df989bf 100644 --- a/.github/matrix.json +++ b/.github/matrix.json @@ -1,24 +1,144 @@ { "include": [ + { + "otp": "27", + "elixir": "1.18.4", + "project": "engine" + }, + { + "otp": "26", + "elixir": "1.18.4", + "project": "engine" + }, + { + "otp": "27", + "elixir": "1.17", + "project": "engine" + }, + { + "otp": "26", + "elixir": "1.17", + "project": "engine" + }, + { + "otp": "25", + "elixir": "1.17", + "project": "engine" + }, + { + "otp": "26", + "elixir": "1.16", + "project": "engine" + }, { "otp": "25", + "elixir": "1.16", + "project": "engine" + }, + { + "otp": "26", "elixir": "1.15.8", "project": "engine" }, { "otp": "25", "elixir": "1.15.8", - "project": "expert" + "project": "engine" + }, + { + "otp": "27", + "elixir": "1.18.4", + "project": "expert_credo" + }, + { + "otp": "26", + "elixir": "1.18.4", + "project": "expert_credo" + }, + { + "otp": "27", + "elixir": "1.17", + "project": "expert_credo" + }, + { + "otp": "26", + "elixir": "1.17", + "project": "expert_credo" + }, + { + "otp": "25", + "elixir": "1.17", + "project": "expert_credo" + }, + { + "otp": "26", + "elixir": "1.16", + "project": "expert_credo" + }, + { + "otp": "25", + "elixir": "1.16", + "project": "expert_credo" + }, + { + "otp": "26", + "elixir": "1.15.8", + "project": "expert_credo" }, { "otp": "25", "elixir": "1.15.8", "project": "expert_credo" }, + { + "otp": "27", + "elixir": "1.18.4", + "project": "forge" + }, + { + "otp": "26", + "elixir": "1.18.4", + "project": "forge" + }, + { + "otp": "27", + "elixir": "1.17", + "project": "forge" + }, + { + "otp": "26", + "elixir": "1.17", + "project": "forge" + }, + { + "otp": "25", + "elixir": "1.17", + "project": "forge" + }, + { + "otp": "26", + "elixir": "1.16", + "project": "forge" + }, + { + "otp": "25", + "elixir": "1.16", + "project": "forge" + }, + { + "otp": "26", + "elixir": "1.15.8", + "project": "forge" + }, { "otp": "25", "elixir": "1.15.8", "project": "forge" + }, + { + "otp": "27.3.4.1", + "elixir": "1.17.3", + "project": "expert" } ] } \ No newline at end of file diff --git a/matrix.exs b/matrix.exs index 7e7929ec..b1709a98 100644 --- a/matrix.exs +++ b/matrix.exs @@ -1,30 +1,22 @@ Mix.install([:jason]) -projects = [ - "engine", - "expert", - "expert_credo", - "forge" -] - -# TODO(#44): renable these once we make the repo public versions = [ - # %{elixir: "1.18.1", otp: "27"}, - # %{elixir: "1.18.1", otp: "26"}, - # %{elixir: "1.17", otp: "27"}, - # %{elixir: "1.17", otp: "26"}, - # %{elixir: "1.17", otp: "25"}, - # %{elixir: "1.16", otp: "26"}, - # %{elixir: "1.16", otp: "25"}, - # %{elixir: "1.15.8", otp: "26"}, + %{elixir: "1.18.4", otp: "27"}, + %{elixir: "1.18.4", otp: "26"}, + %{elixir: "1.17", otp: "27"}, + %{elixir: "1.17", otp: "26"}, + %{elixir: "1.17", otp: "25"}, + %{elixir: "1.16", otp: "26"}, + %{elixir: "1.16", otp: "25"}, + %{elixir: "1.15.8", otp: "26"}, %{elixir: "1.15.8", otp: "25"} ] %{ include: - for project <- projects, version <- versions do + for project <- ["engine", "expert_credo", "forge"], version <- versions do Map.put(version, :project, project) - end + end ++ [%{elixir: "1.17.3", otp: "27.3.4.1", project: "expert"}] } |> Jason.encode!(pretty: true) |> then(&File.write!(".github/matrix.json", &1)) From 5902ef9dde6fecefda44150277a0e732fef700ba Mon Sep 17 00:00:00 2001 From: Mitchell Hanberg Date: Sat, 6 Sep 2025 17:52:08 -0700 Subject: [PATCH 2/3] fixup! ci: update testing matrix --- matrix.exs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/matrix.exs b/matrix.exs index b1709a98..095ba13d 100644 --- a/matrix.exs +++ b/matrix.exs @@ -1,15 +1,12 @@ Mix.install([:jason]) versions = [ - %{elixir: "1.18.4", otp: "27"}, - %{elixir: "1.18.4", otp: "26"}, + %{elixir: "1.18.4", otp: "28"}, + %{elixir: "1.18", otp: "27"}, + %{elixir: "1.18", otp: "26"}, %{elixir: "1.17", otp: "27"}, %{elixir: "1.17", otp: "26"}, - %{elixir: "1.17", otp: "25"}, %{elixir: "1.16", otp: "26"}, - %{elixir: "1.16", otp: "25"}, - %{elixir: "1.15.8", otp: "26"}, - %{elixir: "1.15.8", otp: "25"} ] %{ From 624a80493b0edaa3065c6a779b1a40829e28681f Mon Sep 17 00:00:00 2001 From: Mitchell Hanberg Date: Sat, 6 Sep 2025 17:53:50 -0700 Subject: [PATCH 3/3] fixup! ci: update testing matrix --- .github/matrix.json | 77 ++++++++++----------------------------------- 1 file changed, 16 insertions(+), 61 deletions(-) diff --git a/.github/matrix.json b/.github/matrix.json index 8df989bf..9a7d5d12 100644 --- a/.github/matrix.json +++ b/.github/matrix.json @@ -1,58 +1,48 @@ { "include": [ { - "otp": "27", - "elixir": "1.18.4", - "project": "engine" - }, - { - "otp": "26", + "otp": "28", "elixir": "1.18.4", "project": "engine" }, { "otp": "27", - "elixir": "1.17", + "elixir": "1.18", "project": "engine" }, { "otp": "26", - "elixir": "1.17", + "elixir": "1.18", "project": "engine" }, { - "otp": "25", + "otp": "27", "elixir": "1.17", "project": "engine" }, { "otp": "26", - "elixir": "1.16", - "project": "engine" - }, - { - "otp": "25", - "elixir": "1.16", + "elixir": "1.17", "project": "engine" }, { "otp": "26", - "elixir": "1.15.8", + "elixir": "1.16", "project": "engine" }, { - "otp": "25", - "elixir": "1.15.8", - "project": "engine" + "otp": "28", + "elixir": "1.18.4", + "project": "expert_credo" }, { "otp": "27", - "elixir": "1.18.4", + "elixir": "1.18", "project": "expert_credo" }, { "otp": "26", - "elixir": "1.18.4", + "elixir": "1.18", "project": "expert_credo" }, { @@ -65,39 +55,24 @@ "elixir": "1.17", "project": "expert_credo" }, - { - "otp": "25", - "elixir": "1.17", - "project": "expert_credo" - }, { "otp": "26", "elixir": "1.16", "project": "expert_credo" }, { - "otp": "25", - "elixir": "1.16", - "project": "expert_credo" - }, - { - "otp": "26", - "elixir": "1.15.8", - "project": "expert_credo" - }, - { - "otp": "25", - "elixir": "1.15.8", - "project": "expert_credo" + "otp": "28", + "elixir": "1.18.4", + "project": "forge" }, { "otp": "27", - "elixir": "1.18.4", + "elixir": "1.18", "project": "forge" }, { "otp": "26", - "elixir": "1.18.4", + "elixir": "1.18", "project": "forge" }, { @@ -110,31 +85,11 @@ "elixir": "1.17", "project": "forge" }, - { - "otp": "25", - "elixir": "1.17", - "project": "forge" - }, { "otp": "26", "elixir": "1.16", "project": "forge" }, - { - "otp": "25", - "elixir": "1.16", - "project": "forge" - }, - { - "otp": "26", - "elixir": "1.15.8", - "project": "forge" - }, - { - "otp": "25", - "elixir": "1.15.8", - "project": "forge" - }, { "otp": "27.3.4.1", "elixir": "1.17.3",