Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed colors of modules and aliases #278

Closed
wants to merge 1 commit into from
Closed

changed colors of modules and aliases #278

wants to merge 1 commit into from

Conversation

jansowinski
Copy link

@jansowinski jansowinski commented Feb 4, 2017

Now module names have the same color as keywords. Syntax coloring also does't work as it should when it comes to coloring what's after 'require' keyword. This is affected by elixirAlias. That's my proposal of changes.

Before:
zrzut ekranu 2017-02-04 14 21 31

After:
zrzut ekranu 2017-02-04 14 51 44

Copy link
Contributor

@jbodah jbodah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW vim-ruby also casts module names to Type. Not near a computer to check how it isn't on my local but I don't recall having this issue. What color scheme are you using?

@jansowinski
Copy link
Author

jansowinski commented Feb 6, 2017

I don't have this kind of issues with vim-ruby and on different color schemes (I use vim-monokai, but on default vim colors it doesn't work as well)

@jbodah
Copy link
Contributor

jbodah commented Feb 6, 2017

I get a similar problem when I load that scheme, however I think the problem is your colorscheme - not vim-elixir. The colorscheme was generated from textmate instead of being custom made for vim. This monokai scheme for example highlights Type and Define differently which the one you linked me does not

If you look at the source it looks like things were hacked to work for Ruby which I believe is why you don't get an issue there: https://github.com/sickill/vim-monokai/blob/master/colors/monokai.vim#L64

I would recommend patching the colorscheme to highlight Type and Define differently. For an example, here's my own:

1__repo_ex____repos_modern-pastry_deps_ecto_lib_ecto__-_vim__vim_

You can set this line to whatever you want

@jansowinski
Copy link
Author

jansowinski commented Feb 6, 2017

It seams that you're right @jbodah . I fixed my color scheme instead and everythinig works as it should. Thanks for help, I'm closing PR.

@jansowinski jansowinski closed this Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants