OTP 24 compatibility: extract line number from location tuple #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTP 24 includes changes in the Erlang compiler to include column number information. Column information obtained from the chunk data is not currently handled by
WorkspaceSymbols.build_result/4
and provokes anArithmeticError
exception as decribed in #503:elixir-ls/apps/language_server/lib/language_server/providers/workspace_symbols.ex
Lines 480 to 490 in b9f55cc
This PR changes
build_result/4
to extract the line number when a tuple{line, column}
is read from the chunk data.