Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typespecs for match #45

Merged
merged 1 commit into from Sep 8, 2019
Merged

Conversation

axelson
Copy link
Member

@axelson axelson commented Sep 8, 2019

It currently returns a string not bindings

It currently returns a string not bindings
@asummers
Copy link
Contributor

asummers commented Sep 8, 2019

You should also fix the typespec for match because it's wrong.

@axelson
Copy link
Member Author

axelson commented Sep 8, 2019

@asummers Are you talking about ElixirSense.Providers.Eval.match/1? That spec looks correct to me:

@type binding :: {name :: String.t(), value :: String.t()}
@type bindings :: [binding] | :no_match | {:error, message :: String.t()}
@spec match(String.t()) :: bindings

@asummers
Copy link
Contributor

asummers commented Sep 8, 2019

I'm wrong, you're good to go =)

@axelson
Copy link
Member Author

axelson commented Sep 8, 2019

Haha, ok 😃, going to merge it.

@axelson axelson merged commit c8662d7 into elixir-lsp:master Sep 8, 2019
@axelson axelson deleted the typespec-fixes branch September 8, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants