Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper implementation of NxSignal.istft #5

Closed
polvalente opened this issue Jan 27, 2023 · 0 comments · Fixed by #9
Closed

Add proper implementation of NxSignal.istft #5

polvalente opened this issue Jan 27, 2023 · 0 comments · Fixed by #9

Comments

@polvalente
Copy link
Collaborator

The previous version would just perform ifft for each frame. We actually want to apply the inversion with overlap_and_add.

20ee79b has the previous code still.
@polvalente polvalente added this to the Release 0.5.0 milestone Jan 27, 2023
@polvalente polvalente changed the title Add proper implementation of NxSignal.istft [0.5.0 optional] Add proper implementation of NxSignal.istft Jan 27, 2023
@polvalente polvalente changed the title [0.5.0 optional] Add proper implementation of NxSignal.istft Add proper implementation of NxSignal.istft Jan 27, 2023
@polvalente polvalente removed this from the Release 0.5.0 milestone Jan 27, 2023
@polvalente polvalente mentioned this issue Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: proper NxSignal.istft/3 implementation elixir-nx/nx_signal
1 participant
@polvalente