Skip to content

Replace eqc with stream_data #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2021
Merged

Replace eqc with stream_data #149

merged 3 commits into from
Apr 16, 2021

Conversation

@whatyouhide
Copy link
Collaborator

@whatyouhide whatyouhide commented Apr 16, 2021 •
edited
Loading

Reasons:

  1. stream_data is faster: one of the test files went from 0.6s to 0.2s, the other from 0.5s to 0.2s when switching to stream_data
  2. We don't need the additional mix eqc.install --mini step in order to run the test suite

Thoughts @tony612?

@whatyouhide whatyouhide requested a review from tony612 April 16, 2021 10:09
@whatyouhide
Copy link
Collaborator Author

whatyouhide commented Apr 16, 2021

Actually, let me for once take the liberty to apologize rather than ask for permissions 😄, I'll merge this and move on so that I can also setup GitHub Actions to run CI (#148). @tony612 please let me know if this causes any problems and we can always revert or revert in part!

@whatyouhide whatyouhide merged commit 0ee844d into master Apr 16, 2021
@whatyouhide whatyouhide deleted the stream_data branch April 16, 2021 12:56
whatyouhide added a commit that referenced this pull request Apr 16, 2021
@whatyouhide
Replace eqc with stream_data (#149)
4db8907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tony612 tony612 Awaiting requested review from tony612

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whatyouhide