From 2265e89c84b5df1ccef3c9f2789229733b3c6f75 Mon Sep 17 00:00:00 2001 From: Chris Keathley Date: Thu, 20 Jul 2017 09:49:16 -0400 Subject: [PATCH] Add the correct error message for text queries --- lib/wallaby/query/error_message.ex | 2 ++ test/wallaby/query/error_message_test.exs | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/lib/wallaby/query/error_message.ex b/lib/wallaby/query/error_message.ex index 715412f3..02e14a56 100644 --- a/lib/wallaby/query/error_message.ex +++ b/lib/wallaby/query/error_message.ex @@ -113,6 +113,8 @@ defmodule Wallaby.Query.ErrorMessage do def method(:file_field, true), do: "file fields" def method(:file_field, false), do: "file field" + def method(:text, true), do: "elements with the text" + def method(:text, false), do: "element with the text" def short_method(:css, count) when count > 1, do: "elements" def short_method(:css, count) when count == 0, do: "elements" diff --git a/test/wallaby/query/error_message_test.exs b/test/wallaby/query/error_message_test.exs index a3442926..64f171ca 100644 --- a/test/wallaby/query/error_message_test.exs +++ b/test/wallaby/query/error_message_test.exs @@ -91,6 +91,24 @@ defmodule Wallaby.Query.ErrorMessageTest do assert message =~ ~r/query is invalid/ end + + test "with text queries" do + message = + Query.text("test") + |> ErrorMessage.message(:not_found) + |> format + assert message == format """ + Expected to find 1, visible element with the text 'test' but 0, visible elements with the text were found. + """ + + message = + Query.text("test", count: 2) + |> ErrorMessage.message(:not_found) + |> format + assert message == format """ + Expected to find 2, visible elements with the text 'test' but 0, visible elements with the text were found. + """ + end end describe "visibility/1" do