Skip to content

Add RSS feed#2009

Merged
burden merged 4 commits into
elixirschool:masterfrom
delta1:rss
Oct 5, 2019
Merged

Add RSS feed#2009
burden merged 4 commits into
elixirschool:masterfrom
delta1:rss

Conversation

@delta1
Copy link
Copy Markdown
Contributor

@delta1 delta1 commented Oct 1, 2019

Add RSS feed as per issue #1999

@delta1 delta1 requested a review from a team as a code owner October 1, 2019 07:35
Br1ght0ne
Br1ght0ne previously approved these changes Oct 1, 2019
Copy link
Copy Markdown
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get the site name and description from English locale, let's do it.

Comment thread feed.xml
Comment thread feed.xml Outdated
Comment thread feed.xml Outdated
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
@delta1
Copy link
Copy Markdown
Contributor Author

delta1 commented Oct 1, 2019

Thanks for the feedback @lex111 - I did accept the changes however I have not tested them locally

@delta1
Copy link
Copy Markdown
Contributor Author

delta1 commented Oct 2, 2019

Tested locally and working perfectly 👍

@doomspork doomspork requested a review from a team October 2, 2019 16:54
@burden
Copy link
Copy Markdown
Member

burden commented Oct 2, 2019

This definitely looks like an rss/atom feed. Has any one had a chance to checkout the jekyll-feed plugin?

@doomspork
Copy link
Copy Markdown
Member

@burden as the Jekyll master I'll defer to you on this PR and the plugins. Happy to weigh in though if need be 😁

lex111
lex111 previously approved these changes Oct 2, 2019
Copy link
Copy Markdown
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's not bad for a first run 👍

Copy link
Copy Markdown
Member

@burden burden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick update to the description tag for validation purposes and we're good to deploy.

Comment thread feed.xml Outdated
Copy link
Copy Markdown
Member

@burden burden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to merge. thanks @delta1 for this one 🎉

@burden burden merged commit 71515cf into elixirschool:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants