Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSS feed #2009

Merged
merged 4 commits into from
Oct 5, 2019
Merged

Add RSS feed #2009

merged 4 commits into from
Oct 5, 2019

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Oct 1, 2019

Add RSS feed as per issue #1999

@delta1 delta1 requested a review from a team as a code owner October 1, 2019 07:35
Br1ght0ne
Br1ght0ne previously approved these changes Oct 1, 2019
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get the site name and description from English locale, let's do it.

feed.xml Show resolved Hide resolved
feed.xml Outdated Show resolved Hide resolved
feed.xml Outdated Show resolved Hide resolved
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
@delta1
Copy link
Contributor Author

delta1 commented Oct 1, 2019

Thanks for the feedback @lex111 - I did accept the changes however I have not tested them locally

@delta1
Copy link
Contributor Author

delta1 commented Oct 2, 2019

Tested locally and working perfectly 👍

@doomspork doomspork requested a review from a team October 2, 2019 16:54
@burden
Copy link
Member

burden commented Oct 2, 2019

This definitely looks like an rss/atom feed. Has any one had a chance to checkout the jekyll-feed plugin?

@doomspork
Copy link
Member

@burden as the Jekyll master I'll defer to you on this PR and the plugins. Happy to weigh in though if need be 😁

lex111
lex111 previously approved these changes Oct 2, 2019
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's not bad for a first run 👍

Copy link
Member

@burden burden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick update to the description tag for validation purposes and we're good to deploy.

feed.xml Outdated Show resolved Hide resolved
Copy link
Member

@burden burden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to merge. thanks @delta1 for this one 🎉

@burden burden merged commit 71515cf into elixirschool:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants