-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RSS feed #2009
Add RSS feed #2009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get the site name and description from English locale, let's do it.
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
Thanks for the feedback @lex111 - I did accept the changes however I have not tested them locally |
Tested locally and working perfectly 👍 |
This definitely looks like an rss/atom feed. Has any one had a chance to checkout the jekyll-feed plugin? |
@burden as the Jekyll master I'll defer to you on this PR and the plugins. Happy to weigh in though if need be 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's not bad for a first run 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick update to the description tag for validation purposes and we're good to deploy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to merge. thanks @delta1 for this one 🎉
Add RSS feed as per issue #1999