update ecto changesets lesson to use Friends.Person module from ecto basics lesson#2011
Merged
Merged
Conversation
doomspork
requested changes
Oct 2, 2019
Member
doomspork
left a comment
doomspork
left a comment
There was a problem hiding this comment.
@delta1 these are really awesome changes you're submitting, thank you so much!! As with the other PR, could we bump the lesson version here from 1.1.1 to 1.2.0?
These versions are how the Translation Reports work for the different langauges: https://elixirschool.com/es/report/
Contributor
Author
|
You're most welcome! Thank you for the information about the translations - I've bumped the version! Cheers |
doomspork
approved these changes
Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update ecto changesets lesson to use Friends.Person module from ecto basics lesson - issue #1756