Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ecto changesets lesson to use Friends.Person module from ecto basics lesson #2011

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@delta1
Copy link
Contributor

delta1 commented Oct 1, 2019

update ecto changesets lesson to use Friends.Person module from ecto basics lesson - issue #1756

@delta1 delta1 requested a review from elixirschool/english as a code owner Oct 1, 2019
Copy link
Member

doomspork left a comment

@delta1 these are really awesome changes you're submitting, thank you so much!! As with the other PR, could we bump the lesson version here from 1.1.1 to 1.2.0?

These versions are how the Translation Reports work for the different langauges: https://elixirschool.com/es/report/

@delta1

This comment has been minimized.

Copy link
Contributor Author

delta1 commented Oct 3, 2019

You're most welcome! Thank you for the information about the translations - I've bumped the version!

Cheers

@delta1 delta1 requested a review from doomspork Oct 3, 2019
@doomspork doomspork merged commit 05a4e77 into elixirschool:master Oct 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.