fix(profile): incorrect "pinned post" label shown on other account - #3320
Merged
shuuji3 merged 1 commit intoJun 29, 2025
Conversation
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for elk-docs canceled.
|
nove-b
changed the title
nove-b
changed the title
shuuji3
approved these changes
Jun 29, 2025
shuuji3
left a comment
shuuji3
left a comment
Member
There was a problem hiding this comment.
Thank you for the first PR and no need to apologize 🙂 It's perfect solution and no issue on the PR too.
I also confirmed the fix with the pinned post on the other user's timeline.
Before
https://deploy-preview-3319--elk-zone.netlify.app/universeodon.com/@shuuji3_dev@mastodon.social
After
https://deploy-preview-3320--elk-zone.netlify.app/universeodon.com/@shuuji3_dev@mastodon.social
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3161
Issue
A post authored by the current user and displayed on someone else's profile page was incorrectly shown as a "pinned post," even though it wasn't actually pinned by the profile owner.
Solution
Added logic to check whether the account of the profile being viewed matches the account of the post.
This ensures that pinned posts are only shown on the author's own profile, and not on others' profiles.
This is my first pull request to this project, so I apologize in advance if I've missed any contribution guidelines.