Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme updates #3791

Merged
merged 19 commits into from
Apr 24, 2024
Merged

Theme updates #3791

merged 19 commits into from
Apr 24, 2024

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Apr 23, 2024

This addresses items remaining form Theme css suggestions #2284

This also adds a couple of more variants gold and blue, to ensure the core css structure was easy to change via variant files

Of course going through all this you find other template / php bugs so there were addressed here as well.

Improved slidedown function with a callback option

Added a sticky menu feature for themes to use should they want (gold does this)

General cleanup along the way

@Spuds Spuds added this to the 2.0 milestone Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.50%. Comparing base (1ed00a8) to head (c3e98ef).
Report is 1 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3791      +/-   ##
=================================================
- Coverage          43.50%   43.50%   -0.01%     
- Complexity         13905    13910       +5     
=================================================
  Files                347      348       +1     
  Lines              74759    74773      +14     
=================================================
+ Hits               32527    32529       +2     
- Misses             42232    42244      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spuds Spuds merged commit f737f32 into elkarte:development Apr 24, 2024
9 of 10 checks passed
@Spuds Spuds deleted the ThemeUpdates branch May 1, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant