Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send ajax #728

Merged
merged 3 commits into from Jul 22, 2013
Merged

Send ajax #728

merged 3 commits into from Jul 22, 2013

Conversation

@emanuele45
Copy link
Contributor

emanuele45 commented Jul 20, 2013

It needs some improvement, but I think it may work.

emanuele45 added 3 commits Jul 20, 2013
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
@Spuds

This comment has been minimized.

Copy link

Spuds commented on b010273 Jul 20, 2013

Very nice ... I don't care what Norv says about you 😸

@norv

This comment has been minimized.

Copy link
Contributor

norv commented Jul 21, 2013

Ema always makes the small niceties nicer. I thought that's common knowledge.

Thanks! Lets try this. Send topic used to have quite an outdated feel attached to it IMHO, ajaxifying it brings it more as it should behave. On a side note, I'm glad we have more action api used actively, it'll help to review its uses and needs. I'm not entirely convinced of the tweaks we needed lately to Security.php, but I may need some time (and implemented use-cases) to think it over.

@emanuele45

This comment has been minimized.

Copy link
Contributor Author

emanuele45 commented Jul 21, 2013

Yups, I consider the changes to security a sort of "short-term" adjustments, just to get the idea of what we really need/want.

@emanuele45

This comment has been minimized.

Copy link
Contributor Author

emanuele45 commented Jul 21, 2013

For example a possibility could be to just change fatal_error to know about the API and return an appropriate XML error when it's needed instead of a webpage.

norv added a commit that referenced this pull request Jul 22, 2013
@norv norv merged commit 2a03210 into elkarte:master Jul 22, 2013
@norv

This comment has been minimized.

Copy link
Contributor

norv commented Jul 22, 2013

I think that's appropriate, and probably (unless I'm missing some issue) the way to handle this. IIRC Request object knows if it's xml, fatal_error() can inquire it. (I was just about to say Response class, but it seems it's not its time yet...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.