Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new class to handle "positioning" and its use in the poster area #740

Closed
wants to merge 1 commit into from

Conversation

@emanuele45
Copy link
Contributor

emanuele45 commented Jul 22, 2013

Only for review

I took inspiration from the error class and the layer class (more from the error since there are still a couple of comments from there lol).

Opinions?

…isplay)

Signed-off-by: emanuele <emanuele45@gmail.com>
@StealthWombat

This comment has been minimized.

Copy link
Contributor

StealthWombat commented Jul 22, 2013

Umm, do we really need this? You apear to be taking markup flexibility out of templates and hiding it where themers are not going to be able to access it.

Unless there are sound performance and/or security reasons for this change, I would suggest sticking with what we already have. It works perfectly well.

One thing you have to understand is that of you want to encourage theming, it has to be flexible and comprehensible. Most themers do not find a sources files comprehensible, and from their perspective it certainly is not flexible. TBH, without spending a couple of hours studying it and asking a lot of questions, I can't even tell what all the ramifications of this PR are.

Can you explain the advantages?

@norv

This comment has been minimized.

Copy link
Contributor

norv commented Jul 23, 2013

As an aside note. Please see https://github.com/elkarte/Elkarte/wiki/Make-a-new-theme, hands-on tutorial for a new themer. I started up the page, but it's just a stub I'm afraid. Please correct it and add to it. What is there to know, where to look, how to change basic things.

@emanuele45

This comment has been minimized.

Copy link
Contributor Author

emanuele45 commented Jul 25, 2013

Can you explain the advantages?

All the advantages are things you are not interested in for sure. 😛 (And I knew that from the beginning. 👼 )
It's the usual trade-off between me and you, but now I have other things to do, we will fight another time.

@emanuele45 emanuele45 closed this Jul 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.