Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML Translation #11

Merged
merged 9 commits into from Apr 1, 2019

Conversation

@ellikap6
Copy link
Owner

commented Mar 18, 2019

uncompleted, but I want to push what I have so far

ellikap6 added 2 commits Mar 18, 2019
What I was able to accomplish so far of ML translation. It's broken and
uncompleted, but I want to push what I have so far
I have implemented the Guided project to the fullest I can as of now.
Unfortunately I ran into a problem of being able to see my progress by
running the server, because the issue of all the machine learning things
being implemented has made it so the page no longer works locally.

@ellikap6 ellikap6 changed the title What I was able to accomplish so far of ML translation. It's broken and ML Translation Mar 24, 2019

@tsalako

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

Code looks good. Can you add a screenshot or a demo of some sort?

@@ -49,6 +49,11 @@ function showMessageFormIfViewingSelf() {
/** Fetches messages and add them to the page. */
function fetchMessages() {
const url = '/messages?user=' + parameterUsername;
const parameterLanguage = urlParams.get('language');
let url = '/messages?user=' + parameterUsername;

This comment has been minimized.

Copy link
@tsalako

tsalako Mar 25, 2019

Collaborator

is there a reason you are setting this twice?

This comment has been minimized.

Copy link
@ellikap6

ellikap6 Apr 1, 2019

Author Owner

i got rid of the redundancy

@ellikap6

This comment has been minimized.

Copy link
Owner Author

commented Apr 1, 2019

Screenshot (25)

@tsalako
tsalako approved these changes Apr 1, 2019
Copy link
Collaborator

left a comment

Looks good! Feel free to merge.

@ellikap6 ellikap6 merged commit 9a5a00e into master Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.