Improve speed of bool-to-int conversions #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2018 02:11
Use a simple function that tests the bool and returns 0 for false and 1 for true, rather than a map that does the same thing, as Go appears to compile the former into much faster code.
Use a simple function that tests the bool and returns 0 for false and 1 for true, rather than a map that does the same thing, as Go appears to compile the former into much faster code.
|
This should fix #795. |
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 169 169
Lines 9781 9781
=======================================
Hits 7859 7859
Misses 1473 1473
Partials 449 449
Continue to review full report at Codecov.
|
jcburley
changed the title
elliotchance
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
elliotchance
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a simple function that tests the bool and returns 0 for false and
1 for true, rather than a map that does the same thing, as Go appears
to compile the former into much faster code.
This change is