Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup back ticks and apostrophes #13

Closed
elliotchance opened this issue Dec 12, 2021 · 4 comments
Closed

Cleanup back ticks and apostrophes #13

elliotchance opened this issue Dec 12, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@elliotchance
Copy link
Owner

Backticks (`) and UTF-8 apostrophes should be replaced with regular apostrophes.

@elliotchance elliotchance added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 12, 2021
@mkim219
Copy link
Contributor

mkim219 commented Dec 26, 2021

Hi @elliotchance. Can I work on this issue?

@elliotchance
Copy link
Owner Author

@mkim219 yes - you don't need to ask permission, just put in a PR

@mkim219
Copy link
Contributor

mkim219 commented Dec 27, 2021

@elliotchance I have a question about this issue. If user inputs Backticks (`) and UTF-8 apostrophes, this should be converted into regular apostrophes?

@elliotchance
Copy link
Owner Author

Yes. So this really means backtick and variations of smart quotes - the 4 characters that make up the single and double for open an close. You might find this helpful: https://stackoverflow.com/questions/9401312/how-to-replace-curly-quotation-marks-in-a-string-using-javascript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants