Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add highlighting row feature #14

Merged
merged 2 commits into from Dec 19, 2021
Merged

Add highlighting row feature #14

merged 2 commits into from Dec 19, 2021

Conversation

mkim219
Copy link
Contributor

@mkim219 mkim219 commented Dec 17, 2021 •
edited

Issue #12

what I have done

  • Add background color in style property
  • Create a method highlightTableRow(id) for assigning selected row
  • Add mouseEnter event for highlighting table row
  • Add mouseLeave event for removing highlight table row

This change is Reviewable

@mkim219
Copy link
Contributor Author

mkim219 commented Dec 17, 2021

Should I also consider when the mouse leave the table row(change background to white)? please let me know

@elliotchance
Copy link
Owner

Thanks for submitting this @mkim219 - yes, I think it would be better if it deselected the row when the mouse leaves so it doesn't seem "sticky".

@mkim219
Copy link
Contributor Author

mkim219 commented Dec 19, 2021

I have added the feature that remove highlight when mouse leave the table row.

@elliotchance elliotchance merged commit ab51696 into elliotchance:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkim219 @elliotchance