Add backtick and Unicode replacement #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.html
Outdated
| @@ -24,7 +24,10 @@ | |||
| .replace(/</g, "<") | |||
| .replace(/>/g, ">") | |||
| .replace(/"/g, """) | |||
| .replace(/'/g, "'"); | |||
| .replace(/'/g, "'") | |||
There was a problem hiding this comment.
This changes how the tracks are displayed but doesn't address the issue at all. The parser needs to replace these. You will also need to include unit tests.
Here is a similar diff: #2
elliotchance
requested changes
Dec 28, 2021
parse.js
Outdated
| @@ -75,6 +75,9 @@ function parseTracks(str, lineMode) { | |||
| .replace(/`/g, "'") | |||
| .replace(/[\u2018\u2019]/g, "'"); | |||
|
|
|||
| // Replace double smart quotes with regular apostrophes | |||
| track.title = track.title.replace(/[\u201C\u201D]/g, "'"); | |||
There was a problem hiding this comment.
Smart double quotes need to be replaced with double quotes ".
elliotchance
approved these changes
Dec 28, 2021
|
Thanks @mkim219 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #13
Replace back-tick to
'Replace single and double curly quotation to
'and"This change is