Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenized emails #165

Merged
merged 3 commits into from Aug 29, 2013

Conversation

Projects
None yet
1 participant
@practicingruby
Copy link
Member

practicingruby commented Aug 23, 2013

This branch will integrate user tokens into our emails

practicingruby added some commits Aug 23, 2013

@practicingruby

This comment has been minimized.

Copy link
Member Author

practicingruby commented Aug 24, 2013

@jordanbyron: I had originally intended to also tokenize the conversation mailers on this branch, but then I realized:

  • We haven't made those mailers send individual emails yet.
  • The conversation mailer tests are terrible and possibly even wrong (#166)
  • We might get away with the broadcast mailer being slow because it only affects me, but we can't have users waiting 10-20s or more to publish a comment.

So all of those things lead me to think we should ship the broadcast mailer tokenizer for now, and leave the comments mailer work for later, once we've sorted out our delayed_job issues. Sound OK?

@practicingruby

This comment has been minimized.

Copy link
Member Author

practicingruby commented Aug 24, 2013

@jordanbyron Sorry for the noise... I'll squash these commits as soon as I get things working again. Then I'll take a break for a day or two to recharge the batteries.

@practicingruby

This comment has been minimized.

Copy link
Member Author

practicingruby commented Aug 24, 2013

Done! This is deployed and hopefully ready to merge.

@practicingruby

This comment has been minimized.

Copy link
Member Author

practicingruby commented Aug 26, 2013

@jordanbyron Let me know if you think this is good to merge... it only affects broadcast mailer.

@practicingruby practicingruby merged commit f673b9f into master Aug 29, 2013

1 check passed

default The Travis CI build passed
Details

@practicingruby practicingruby deleted the tokenized_emails branch Aug 29, 2013

@practicingruby

This comment has been minimized.

Copy link
Member Author

practicingruby commented Aug 29, 2013

Merged as discussed offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.