Tokenized emails #165

Merged
merged 3 commits into from Aug 29, 2013

Projects

None yet

1 participant

@practicingruby
Member

This branch will integrate user tokens into our emails

@practicingruby
Member

@jordanbyron: I had originally intended to also tokenize the conversation mailers on this branch, but then I realized:

  • We haven't made those mailers send individual emails yet.
  • The conversation mailer tests are terrible and possibly even wrong (#166)
  • We might get away with the broadcast mailer being slow because it only affects me, but we can't have users waiting 10-20s or more to publish a comment.

So all of those things lead me to think we should ship the broadcast mailer tokenizer for now, and leave the comments mailer work for later, once we've sorted out our delayed_job issues. Sound OK?

@practicingruby
Member

@jordanbyron Sorry for the noise... I'll squash these commits as soon as I get things working again. Then I'll take a break for a day or two to recharge the batteries.

@practicingruby
Member

Done! This is deployed and hopefully ready to merge.

@practicingruby
Member

@jordanbyron Let me know if you think this is good to merge... it only affects broadcast mailer.

@practicingruby practicingruby merged commit f673b9f into master Aug 29, 2013

1 check passed

default The Travis CI build passed
Details
@practicingruby practicingruby deleted the tokenized_emails branch Aug 29, 2013
@practicingruby
Member

Merged as discussed offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment