Share by user token #173

Merged
merged 4 commits into from Aug 29, 2013

Projects

None yet

1 participant

@practicingruby
Member

This pull request supports the following behaviors:

  • Logged in users will see full article w. comments as normal
  • With a valid token, guests will see the "shared article" view
  • Without a valid token, guests will see the "that page is protected" error
@practicingruby
Member

@jordanbyron: This is a spike so far... I'd want to clean it up and add testing before attempting a deploy. But can you confirm the general direction? It's going to cause some problems with #169, but I want to focus on getting this one tested and merged first, since it's the more important of the two.

@practicingruby
Member

I just added the behavior of redirecting existing share links to user tokens, and filling the share box in with the user token links (as a temporary measure, we'll overhaul the UI). I may deploy this in the next day or so for a little while to see what catches fire, but there is still cleanup and testing to be done before we can seriously consider merging.

@practicingruby
Member

I deployed this change temporarily... it's worth noting that the store_location code introduced here leads to weird behavior on login... will need to fix that before merging.

@practicingruby practicingruby merged commit 0455ef9 into master Aug 29, 2013

1 check passed

default The Travis CI build passed
Details
@practicingruby
Member

@jordanbyron: Merged as discussed. The code on this branch deserves more testing and cleanup, but I think we'll do that as we continue to work on the code, rather than trying to get everything perfect right away.

@practicingruby practicingruby deleted the share_by_user_token branch Aug 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment