Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
In Site Registration #76
@jordanbyron: I think the tests should verify the whole resubscirbe process rather than just verifying that they can reach the subscribe page. In theory, that should take mostly the same path through the code, but I think a complete test would help us catch current or future edge cases.
Other than that, looks good.
@jordanbyron: One question, what happens when a previous subscriber attempts to visit the subscribe page while not logged in? Does it authenticate them and display the problems page, and then they need to click the resubscribe link? If so, that's acceptable, but it may be better to handle that automatically so that they can seamlessly resubscribe without having to explicitly hit the /restart route.
This is not a blocker for deploying this code unless it somehow leads to an inconsistent state to visit /subscribe as a former subscriber that is not logged in, but is something we should look into.
Yes that is the flow. Initially I thought about just re-routing them to the registration process, but that could be super confusing if they never knew their account was disabled by MailChimp.
I also considered changing the MailChimp webhooks to mark those accounts as
Let me know what you think. I plan on deploying this branch within the next hour or so.