Moved classes on the main file to their own files. #6

Merged
merged 3 commits into from Jan 21, 2012

Conversation

Projects
None yet
2 participants
@renato-zannon
Contributor

renato-zannon commented Jan 21, 2012

A small, code gardening, contribution :)

Now, do you think the exceptions deserve their own file too?

@practicingruby

This comment has been minimized.

Show comment
Hide comment
@practicingruby

practicingruby Jan 21, 2012

Been meaning to do this, but it'd be better to organize within a namespaced folder... i.e:

lib/turing_tarpit.rb
lib/turing_tarpit/tape.rb
lib/turing_tarpit/scanner.rb
...

I'd expect lib/turing_tarpit.rb to use require_relative to load all the files in the lib/turing_tarping/ folder. Definitely would accept a pull request for that if you don't mind doing it.

The reason I want these all to be within a namespaced folder is so that we minimize the amount of files that get added to the loadpath if we package this library up as a gem, for example. Right now with this commit, really generic names like "scanner" and "tape" would be added to the lookup path for require

Been meaning to do this, but it'd be better to organize within a namespaced folder... i.e:

lib/turing_tarpit.rb
lib/turing_tarpit/tape.rb
lib/turing_tarpit/scanner.rb
...

I'd expect lib/turing_tarpit.rb to use require_relative to load all the files in the lib/turing_tarping/ folder. Definitely would accept a pull request for that if you don't mind doing it.

The reason I want these all to be within a namespaced folder is so that we minimize the amount of files that get added to the loadpath if we package this library up as a gem, for example. Right now with this commit, really generic names like "scanner" and "tape" would be added to the lookup path for require

This comment has been minimized.

Show comment
Hide comment
@renato-zannon

renato-zannon Jan 21, 2012

Owner
Owner

renato-zannon replied Jan 21, 2012

practicingruby added a commit that referenced this pull request Jan 21, 2012

Merge pull request #6 from riccieri/master
Moved classes on the main file to their own files.

@practicingruby practicingruby merged commit 24681ef into elm-city-craftworks:master Jan 21, 2012

@practicingruby

This comment has been minimized.

Show comment
Hide comment
@practicingruby

practicingruby Jan 21, 2012

Member

🌻!!!!

Member

practicingruby commented Jan 21, 2012

🌻!!!!

@practicingruby

This comment has been minimized.

Show comment
Hide comment
@practicingruby

practicingruby Jan 21, 2012

Member

I think the exceptions can live where they are now, thanks.

Member

practicingruby commented Jan 21, 2012

I think the exceptions can live where they are now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment