This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
Removing Fuzz.andThen #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows user to case on it using the `Ok` and `Err` instructors, which would make their tests dependant on the `Fuzzer` implementation. elm-package doesn't consider this a major change, but it is one to users who were doing this type of pattern matching.
Resolves #161.
It's sole purpose now is containing the hidden internal type of the Fuzzer, like before.
This was referenced Jul 1, 2017
From my perspective this is ready to merge but of course happy to make adjustments! |
|
Love it! Looks good to me! |
mgold
reviewed
Jul 9, 2017
src/Test/Runner.elm
Outdated
| @@ -373,18 +374,15 @@ type Shrinkable a | |||
| {-| Given a fuzzer, return a random generator to produce a value and a | |||
| Shrinkable. The value is what a fuzz test would have received as input. | |||
There was a problem hiding this comment.
Let's add a comment saying why there is a Result in the return type.
There was a problem hiding this comment.
Good point. Something like this?
|
This looks good to me. I'm sorting through upcoming changes and don't want breaking API on master right this moment though. |
|
I'm cool with saying "this is ready to merge, but let's not push the button
yet."
…On Sun, Jul 9, 2017, 12:45 PM Max Goldstein ***@***.***> wrote:
This looks good to me. I'm sorting through upcoming changes and don't want
breaking API on master right this moment though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCxwH47tNyyGyct8Qh433GMbpYsYXgWks5sMQOtgaJpZM4OLTPO>
.
|
|
Tagging major-release-blocker so we don't forget about this. Merge conflicts suck but I don't think it's worth resolving them now is we're still not ready to merge. Merging onto a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #160 and #161.
This removes Fuzz.andThen making it a breaking change.
It also fixes two points @mgold alluded to before:
Fuzzertype is wrapped in a type instead of being a type alias to prevent people from casing on it. This is not a major change according toelm-packagebut it is to a user who for some reason is casing on the fuzzer now, so it makes sense to me to bundle the change in here.Fuzz.Internalover toFuzz.Some things I think should be wrapped up before merging this:
andThenfor building recusive fuzzers orMsgfuzzers presentable, either by publishing them in a library or linking to them as a sort of cookbook.Test.Runner.fuzzso it doesn't need aDebug.crashanymore (the last in the codebase).