Skip to content
This repository has been archived by the owner on Aug 23, 2018. It is now read-only.

Commit

Permalink
There are many problems with window.Date so stop relying on it.
Browse files Browse the repository at this point in the history
There are just a bunch of problems with relying on the JS Date
representation that I do not think can be solved with the JS
foundation. For example, the ISO 8601 parsing is impure for dates.

It appears that elm-community/elm-time provides similar functionality,
but in a pure way that takes the IANA time zone database into account.

The pure approach could be improved with something like
https://github.com/evancz/time-zone-database-proposal down the line.

Unclear if we should stick with this choice, but I would like to
explore alternatives first.
  • Loading branch information
evancz committed Jul 6, 2017
1 parent fb79e28 commit a892fdf
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 317 deletions.
1 change: 0 additions & 1 deletion elm.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"Bitwise",
"Char",
"Color",
"Date",
"Debug",
"Dict",
"Json.Decode",
Expand Down
194 changes: 0 additions & 194 deletions src/Date.elm

This file was deleted.

117 changes: 0 additions & 117 deletions src/Elm/Kernel/Date.js

This file was deleted.

5 changes: 0 additions & 5 deletions src/Elm/Kernel/Debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,6 @@ function _Debug_toString_dev(v)

if (type === 'object')
{
if (v instanceof Date)
{
return '<' + v.toString() + '>';
}

if (v.elm_web_socket)
{
return '<websocket>';
Expand Down

0 comments on commit a892fdf

Please sign in to comment.