Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upInherit protocol and endpoint when not specified. #12
+11
−1
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
edevil
commented
Jul 7, 2016
|
Based on code from the Phoenix channels JS client. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Voronchuk
commented
Jul 12, 2016
|
+1 to this |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Jul 12, 2016
Contributor
I didn't have @process-bot set up when this issue was opened, but this is what he would have said: https://github.com/elm-lang/virtual-dom/issues/30#issuecomment-232155244
|
I didn't have @process-bot set up when this issue was opened, but this is what he would have said: https://github.com/elm-lang/virtual-dom/issues/30#issuecomment-232155244 |
listrophy
referenced this pull request
Aug 4, 2016
Open
Provide console feedback on improper protocol #13
edevil
added some commits
Jul 7, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
edevil
commented
Nov 25, 2016
|
Can I have some feedback on this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
edevil commentedJul 7, 2016
•
edited
Edited 1 time
-
edevil
edited Jul 21, 2016 (most recent)
This makes it easy to have the same code running in dev/staging/production environments since you are now able to use relative paths instead of absolute paths for the websocket endpoint.
Addresses fbonetti/elm-phoenix-socket#6