New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile with GHC 8.0.2 / LTS 8.1 #1566

Closed
domenkozar opened this Issue Feb 19, 2017 · 10 comments

Comments

Projects
None yet
6 participants
@domenkozar

domenkozar commented Feb 19, 2017

I haven't dug into why, but here's the error:

src/Parse/Helpers.hs:61:13: error:
    • Couldn't match type ‘[Char]’
                     with ‘transformers-0.5.2.0:Control.Monad.Trans.Reader.ReaderT
                             Text.Parsec.Indent.Pos
                             Data.Functor.Identity.Identity
                             (SourceM (Either ParseError a) -> Either ParseError a)’
      Expected type: Text.Parsec.Indent.IndentT
                       Data.Functor.Identity.Identity
                       (SourceM (Either ParseError a) -> Either ParseError a)
        Actual type: SourceName
    • In the first argument of ‘runIndent’, namely ‘sourceName’
      In the expression: runIndent sourceName
      In the expression:
        runIndent sourceName $ runParserT aParser table sourceName input
    • Relevant bindings include
        aParser :: IParser a (bound at src/Parse/Helpers.hs:60:34)
        iParseWithTable :: SourceName
                           -> OpTable -> IParser a -> String -> Either ParseError a
          (bound at src/Parse/Helpers.hs:60:1)

src/Parse/Helpers.hs:215:9: error:
    • Couldn't match type ‘transformers-0.5.2.0:Control.Monad.Trans.Reader.ReaderT
                             Text.Parsec.Indent.Pos m0’
                     with ‘transformers-0.5.2.0:Control.Monad.Trans.State.Lazy.StateT
                             SourcePos Data.Functor.Identity.Identity’
      Expected type: ParsecT String OpTable SourceM ()
        Actual type: Text.Parsec.Indent.IndentParserT
                       String OpTable m0 ()
    • In a stmt of a 'do' block: indented
      In the expression:
        do { n <- whitespace;
             constraint n <?> Syntax.whitespace;
             indented }
      In an equation for ‘spacing’:
          spacing
            = do { n <- whitespace;
                   constraint n <?> Syntax.whitespace;
                   indented }
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Feb 19, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Feb 19, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Feb 19, 2017

Contributor

It's not expected to compile with anything beyond GHC 7.10, see https://github.com/elm-lang/elm-platform/blob/master/installers/BuildFromSource.hs

So this is not a bug report, or unexpected. Elm will start to compile with GHC 8 when Evan decides to switch to that compiler on his development machine. Until then, having this issue here open serves no purpose.

Contributor

jvoigtlaender commented Feb 19, 2017

It's not expected to compile with anything beyond GHC 7.10, see https://github.com/elm-lang/elm-platform/blob/master/installers/BuildFromSource.hs

So this is not a bug report, or unexpected. Elm will start to compile with GHC 8 when Evan decides to switch to that compiler on his development machine. Until then, having this issue here open serves no purpose.

@domenkozar

This comment has been minimized.

Show comment
Hide comment
@domenkozar

domenkozar Feb 20, 2017

I don't think it's an issue because of GHC 8, but rather the newest version of some package.

domenkozar commented Feb 20, 2017

I don't think it's an issue because of GHC 8, but rather the newest version of some package.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Feb 20, 2017

Contributor

That's well possible. Who knows. But it doesn't make a difference. See #1431 and #1479 and #1488 for a similar story. Unless you can say exactly what the offending package is, and why a newer version should be preferred, and how to accomplish that, your issue will be closed. So I suggest you close it yourself, to save Evan the work.

Contributor

jvoigtlaender commented Feb 20, 2017

That's well possible. Who knows. But it doesn't make a difference. See #1431 and #1479 and #1488 for a similar story. Unless you can say exactly what the offending package is, and why a newer version should be preferred, and how to accomplish that, your issue will be closed. So I suggest you close it yourself, to save Evan the work.

@domenkozar

This comment has been minimized.

Show comment
Hide comment
@domenkozar

domenkozar Feb 20, 2017

So Evan doesn't care if the software can't be used on the latest stable compiler even if a patch is provided?

domenkozar commented Feb 20, 2017

So Evan doesn't care if the software can't be used on the latest stable compiler even if a patch is provided?

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Feb 20, 2017

Contributor

I can't answer that question. I only pointed you to information that seems relevant to this issue being open.

Contributor

jvoigtlaender commented Feb 20, 2017

I can't answer that question. I only pointed you to information that seems relevant to this issue being open.

@domenkozar

This comment has been minimized.

Show comment
Hide comment
@domenkozar

domenkozar Feb 23, 2017

For the record, it's indents package bump to 4.0.0

domenkozar commented Feb 23, 2017

For the record, it's indents package bump to 4.0.0

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jul 14, 2017

Member

I will upgrade to a later version of GHC at some point, but it is not a super high priority in the grand scheme of things since getting it installed on Windows, Linux, and Mac to make binaries seems to be quite an ordeal.

That said, maybe there is still something to do in the meantime. I'm not sure what the action item is though, so open a new issue with a specific title and description that suggests a concrete change if that is what you are looking for.

Member

evancz commented Jul 14, 2017

I will upgrade to a later version of GHC at some point, but it is not a super high priority in the grand scheme of things since getting it installed on Windows, Linux, and Mac to make binaries seems to be quite an ordeal.

That said, maybe there is still something to do in the meantime. I'm not sure what the action item is though, so open a new issue with a specific title and description that suggests a concrete change if that is what you are looking for.

@evancz evancz closed this Jul 14, 2017

@h4ck3rm1k3

This comment has been minimized.

Show comment
Hide comment
@h4ck3rm1k3

h4ck3rm1k3 Dec 9, 2017

@domenkozar what is the patch? I am having the same issue on upgrading the https://github.com/h4ck3rm1k3/haskelm to the latest version of haskell.

h4ck3rm1k3 commented Dec 9, 2017

@domenkozar what is the patch? I am having the same issue on upgrading the https://github.com/h4ck3rm1k3/haskelm to the latest version of haskell.

@jerith666

This comment has been minimized.

Show comment
Hide comment
@jerith666

jerith666 Dec 9, 2017

@h4ck3rm1k3 the commit in NixOS/nixpkgs#22932 is NixOS/nixpkgs@afb7d04. It just pins some dependencies at earlier versions -- it doesn't actually make changes to the elm source code to be compatible with the latest versions.

jerith666 commented Dec 9, 2017

@h4ck3rm1k3 the commit in NixOS/nixpkgs#22932 is NixOS/nixpkgs@afb7d04. It just pins some dependencies at earlier versions -- it doesn't actually make changes to the elm source code to be compatible with the latest versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment