New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Error: period in repository name in elm-package.json #1597

Closed
mdgriffith opened this Issue May 28, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@mdgriffith

mdgriffith commented May 28, 2017

A project will build but fail at runtime with Uncaught SyntaxError: Unexpected token . if the repository name contains a period such as https://github.com/mdgriffith/elm.style.git

So, any project that uses this elm-package.json:

{
    "version": "1.0.0",
    "summary": "The elm.style website",
    "repository": "https://github.com/mdgriffith/elm.style.git",
    "license": "BSD3",
    "source-directories": [
        "."
    ],
    "exposed-modules": [
    ],
    "dependencies": {
        "elm-lang/core": "5.0.0 <= v < 6.0.0",
        "elm-lang/html": "2.0.0 <= v < 3.0.0"
    },
    "elm-version": "0.18.0 <= v < 0.19.0"
}

Versions

  • elm 0.18
  • OS: OSX 10.11.6, El Capitan
  • Browser: Chrome, Firefox
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot May 28, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented May 28, 2017

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jul 14, 2017

Member

With 0.19 project names with dots will be ruled out much earlier, so it won't get to this point anymore. Thanks for the report!

Member

evancz commented Jul 14, 2017

With 0.19 project names with dots will be ruled out much earlier, so it won't get to this point anymore. Thanks for the report!

@evancz evancz closed this Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment