New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textured shapes performance issue #119

Closed
etaque opened this Issue Jan 18, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@etaque

etaque commented Jan 18, 2015

Hi,
Textured shapes consume way too much CPU, see this issue:
elm/elm-lang.org#186

(below my original comment)

Hitting this as well with Elm 0.14 on Tacks. Here are Chrome CPU profiling screenshots:

  • with racing area as a filled rect:

54a4979a120000300001ae3e 2015-01-18 18-58-56

  • with racing area as a textured rect (image being 200*200 jpeg file):

54a4979a120000300001ae3e 2015-01-18 18-58-41

@jastice

This comment has been minimized.

Show comment
Hide comment

jastice commented Jan 29, 2015

See also elm/compiler#724

@dy-dx

This comment has been minimized.

Show comment
Hide comment
@dy-dx

dy-dx Mar 17, 2015

I am getting an infinite loop when rendering a textured shape, using this code:

https://gist.github.com/dy-dx/4213cab10354b1c9b060
http://share-elm.com/sprout/55089d4de4b0d720e25d6386

This function keeps calling itself til my browser crashes:
https://github.com/elm-lang/core/blob/master/src/Native/Graphics/Collage.js#L143

dy-dx commented Mar 17, 2015

I am getting an infinite loop when rendering a textured shape, using this code:

https://gist.github.com/dy-dx/4213cab10354b1c9b060
http://share-elm.com/sprout/55089d4de4b0d720e25d6386

This function keeps calling itself til my browser crashes:
https://github.com/elm-lang/core/blob/master/src/Native/Graphics/Collage.js#L143

@dy-dx

This comment has been minimized.

Show comment
Hide comment
@dy-dx

dy-dx Mar 17, 2015

OK, I've got a fix for the issue: dy-dx@b676350

These changes work when I edit the compiled JS from elm-make, but unfortunately I have no idea how to build/test the entire project. Can someone help me out?

dy-dx commented Mar 17, 2015

OK, I've got a fix for the issue: dy-dx@b676350

These changes work when I edit the compiled JS from elm-make, but unfortunately I have no idea how to build/test the entire project. Can someone help me out?

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 11, 2016

Member

Sorry this did not get attention til now! The Graphics.* modules now live in evancz/elm-graphics so I am trying to get stuff migrated over there. I'm hoping this will make it easier to get help on stuff like this!

Member

evancz commented May 11, 2016

Sorry this did not get attention til now! The Graphics.* modules now live in evancz/elm-graphics so I am trying to get stuff migrated over there. I'm hoping this will make it easier to get help on stuff like this!

@evancz evancz closed this May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment