toCode and fromCode should be inverse operations

[TheSeamau5]

So, I saw that toCode and fromCode are not inverse operations. According to the docs, toCode uppercases things for use with the keyboard. I think that this makes no sense. If you really want a function to work to the keyboard, there should be one called toKeyboardCode because from the names, it would seem that toCode and fromCode are inverses.

I found this out as I was testing the core library with elm-check and with this property:

property "Converting to Unicode and back" (\c -> Char.fromCode (Char.toCode c) == c) generator

I got the following errors:

Converting to Unicode and back has failed with the following input: "z"
Converting to Unicode and back has failed with the following input: "ú"
Converting to Unicode and back has failed with the following input: "ő"
Converting to Unicode and back has failed with the following input: "ɀ"
Converting to Unicode and back has failed with the following input: "ɡ"
Converting to Unicode and back has failed with the following input: "ͅ"
Converting to Unicode and back has failed with the following input: "α"
Converting to Unicode and back has failed with the following input: "ё"
Converting to Unicode and back has failed with the following input: "ԑ"
Converting to Unicode and back has failed with the following input: "հ"
Converting to Unicode and back has failed with the following input: "ᵹ"
Converting to Unicode and back has failed with the following input: "ṑ"
Converting to Unicode and back has failed with the following input: "ὑ"
Converting to Unicode and back has failed with the following input: "ⅰ"
Converting to Unicode and back has failed with the following input: "ⓠ"
Converting to Unicode and back has failed with the following input: "ⱀ"
Converting to Unicode and back has failed with the following input: "ⱡ"
Converting to Unicode and back has failed with the following input: "ⳑ"
Converting to Unicode and back has failed with the following input: "ⴑ"
Converting to Unicode and back has failed with the following input: "ꙑ"
Converting to Unicode and back has failed with the following input: "ꜧ"
Converting to Unicode and back has failed with the following input: "ff"
Converting to Unicode and back has failed with the following input: "ｚ"
Converting to Unicode and back has failed with the following input: "z"
Converting to Unicode and back has failed with the following input: "ú"
Converting to Unicode and back has failed with the following input: "đ"
Converting to Unicode and back has failed with the following input: "ő"
Converting to Unicode and back has failed with the following input: "ơ"
Converting to Unicode and back has failed with the following input: "ǡ"
Converting to Unicode and back has failed with the following input: "ʀ"
Converting to Unicode and back has failed with the following input: "ͅ"
Converting to Unicode and back has failed with the following input: "ΐ"
Converting to Unicode and back has failed with the following input: "α"
Converting to Unicode and back has failed with the following input: "а"
Converting to Unicode and back has failed with the following input: "ѡ"
Converting to Unicode and back has failed with the following input: "ґ"
Converting to Unicode and back has failed with the following input: "ⅰ"
Converting to Unicode and back has failed with the following input: "ꞗ"
Converting to Unicode and back has failed with the following input: "z"
Converting to Unicode and back has failed with the following input: "đ"
Converting to Unicode and back has failed with the following input: "ԫ"
Converting to Unicode and back has failed with the following input: "ԫ"

Notice how it fails with the letter z (the first input in the sequence).

[deadfoxygrandpa]

I'd really like a toCode that doesn't convert to uppercase, at least as an option. I'm right now trying to write a text rendering thing in elm-webgl and all my text comes out uppercase all the time because of this.

[deadfoxygrandpa]

I'd really like a toCode that doesn't convert to uppercase, at least as an option. I'm right now trying to write a text rendering thing in elm-webgl and all my text comes out uppercase all the time because of this.

[evancz]

I believe the upper-casing is removed on the master branch, not sure if that resolves all of this.

[evancz]

I believe the upper-casing is removed on the master branch, not sure if that resolves all of this.

[TheSeamau5]

https://github.com/elm-lang/core/pull/134 solved this problem. toCode now doesn't convert to uppercase which is exactly what we wanted and how it should've been and now all is good. 😄

[TheSeamau5]

https://github.com/elm-lang/core/pull/134 solved this problem. toCode now doesn't convert to uppercase which is exactly what we wanted and how it should've been and now all is good. 😄

[kasbah]

Don't you mean #50 solves this problem?

[kasbah]

Don't you mean #50 solves this problem?

[TheSeamau5]

Probably. I just saw that the problem was solved in the merged PR and was super happy so I closed it. I didn't look too much into the history behind the fix, sorry.

[TheSeamau5]

Probably. I just saw that the problem was solved in the merged PR and was super happy so I closed it. I didn't look too much into the history behind the fix, sorry.

[kasbah]

No worries, but I think it would be clearer to report bugs against the master branch if you are able.

[kasbah]

No worries, but I think it would be clearer to report bugs against the master branch if you are able.