Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upProbably outdated documentation #231
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Apr 29, 2015
Contributor
The changes would be very mechanical:
Signal.ChannelbecomesSignal.MailboxSignal.channelbecomesSignal.mailboxSignal.subscribe xbecomesx.signalSignal.send xbecomesSignal.message x.address
That should be it.
|
The changes would be very mechanical:
That should be it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hossameldeen
Apr 29, 2015
Contributor
Done with the mechanical steps. If anyone could review again before sending the PR, that'd be nice. Or should I send the PR directly since I've reviewed? (Excuse me, still learning the etiquette)
The new Graphics.Input.elm: https://github.com/hossameldeenfci/core/blob/patch-1/src/Graphics/Input.elm
The new Graphics.Input.Field.elm: https://github.com/hossameldeenfci/core/blob/patch-2/src/Graphics/Input/Field.elm
|
Done with the mechanical steps. If anyone could review again before sending the PR, that'd be nice. Or should I send the PR directly since I've reviewed? (Excuse me, still learning the etiquette) The new Graphics.Input.elm: https://github.com/hossameldeenfci/core/blob/patch-1/src/Graphics/Input.elm |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Apr 30, 2015
Contributor
Looks good, just one change missing, in this line: the Markdown link to send should now probably go to message as well.
I think it's okay to send the PR then.
|
Looks good, just one change missing, in this line: the Markdown link to I think it's okay to send the PR then. |
This was referenced Apr 30, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Edited. Sent the PR. |
hossameldeen commentedApr 29, 2015
In (Graphics.Input & Graphics.Input.Field)'s documentation, there seems to be referring to Signal.Channel a lot, like in the first line here, and actually all over the examples:
http://package.elm-lang.org/packages/elm-lang/core/2.0.1/Graphics-Input
The API definition seems to be correct, though.
Graphics.Input.Field documentation page:
http://package.elm-lang.org/packages/elm-lang/core/2.0.1/Graphics-Input-Field
Unfortunately, I'm not comfortable enough yet with Signal.Message to fix it myself.