Separate Path and Shape types?

[jvoigtlaender]

The documentation gives the impression that

outlined : LineStyle -> Shape -> Form

and

traced : LineStyle -> Path -> Form

have different types. But they don't. Which can lead to "wrong applications", like for this user.

[hoosierEE]

Yeah, I think you're right about this. The compiler should complain if someone gives traced a circle, or outlined a segment. I experienced this myself, twice. Once because I made the mistake, and twice because I forgot about the first time!

[hoosierEE]

Yeah, I think you're right about this. The compiler should complain if someone gives traced a circle, or outlined a segment. I experienced this myself, twice. Once because I made the mistake, and twice because I forgot about the first time!

[evancz]

I agree, I implemented this in a long long ago time when it wasn't clear whether type aliases would be distinct in some way. In any case, I think it makes sense to hide all the internal details by making both of them a type

[evancz]

I agree, I implemented this in a long long ago time when it wasn't clear whether type aliases would be distinct in some way. In any case, I think it makes sense to hide all the internal details by making both of them a type

[jvoigtlaender]

Cool, I'll send a PR.

[jvoigtlaender]

Cool, I'll send a PR.

[jvoigtlaender]

Closed via https://github.com/elm-lang/core/pull/235.

[jvoigtlaender]

Closed via https://github.com/elm-lang/core/pull/235.

[hoosierEE]

Nice, thanks!

[hoosierEE]

Nice, thanks!