New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog.md quite off for 0.15 #266

Closed
jvoigtlaender opened this Issue Jun 6, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@jvoigtlaender
Contributor

jvoigtlaender commented Jun 6, 2015

If anybody is currently looking at the repo's changelog.md to find out what happened in the 0.15 release, which seems a very reasonable thing to do, they will get some very wrong impressions. For example, the changelog claims that Signal was split into Stream and Varying. It also claims that Channels are now called Inputs.

Delete the file if it serves no purpose? Seems better than giving wrong information.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jun 6, 2015

Contributor

https://github.com/elm-lang/core/pull/42 observes that the changelog is also not accurate concerning the 0.14 release.

Contributor

jvoigtlaender commented Jun 6, 2015

https://github.com/elm-lang/core/pull/42 observes that the changelog is also not accurate concerning the 0.14 release.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jun 8, 2015

Member

Are the facts in there still off, or were they wrong at the time of release and subsequently fixed?

If they are still wrong, lets fix them. I'm not sure what we can do if the 2.0.1 tag is messed up. I guess we can move it around, but that does not seem ideal.

Member

evancz commented Jun 8, 2015

Are the facts in there still off, or were they wrong at the time of release and subsequently fixed?

If they are still wrong, lets fix them. I'm not sure what we can do if the 2.0.1 tag is messed up. I guess we can move it around, but that does not seem ideal.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jun 8, 2015

Contributor

The facts are still off, see the current master version of the file.

I wasn't sure whether there's even interest in fixing (rather than just deleting) it. Given that there have been no complaints about the wrong facts since the 0.15 release, it seems nobody is looking at that file (instead, at the blog posts).

But sure, let's fix the file in master. I wouldn't change the content in the earlier releases retrospectively.

Contributor

jvoigtlaender commented Jun 8, 2015

The facts are still off, see the current master version of the file.

I wasn't sure whether there's even interest in fixing (rather than just deleting) it. Given that there have been no complaints about the wrong facts since the 0.15 release, it seems nobody is looking at that file (instead, at the blog posts).

But sure, let's fix the file in master. I wouldn't change the content in the earlier releases retrospectively.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jun 8, 2015

Contributor

I made a pull request (#268) that I hope captures all corrections and additions.

Contributor

jvoigtlaender commented Jun 8, 2015

I made a pull request (#268) that I hope captures all corrections and additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment