New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Runtime.js pass a linter #285

Closed
rtfeldman opened this Issue Jul 1, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@rtfeldman
Member

rtfeldman commented Jul 1, 2015

It seems like a good idea to have Runtime.js pass a JS linter. This would maximize its compatibility with older browsers and would have essentially no downside.

@Dandandan

This comment has been minimized.

Show comment
Hide comment
@Dandandan

Dandandan Aug 18, 2015

Contributor

ESLint with configuration is added (and some progress has been made to fix all the issues).

Contributor

Dandandan commented Aug 18, 2015

ESLint with configuration is added (and some progress has been made to fix all the issues).

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 22, 2016

Member

Made some progress on this, but it's not an official part of the workflow. We can talk about it in real life if this seems crucially important. My feeling is that this code is not changing a ton, so I'm not sure how much benefit would come from this in terms of bugs avoided.

Member

evancz commented Sep 22, 2016

Made some progress on this, but it's not an official part of the workflow. We can talk about it in real life if this seems crucially important. My feeling is that this code is not changing a ton, so I'm not sure how much benefit would come from this in terms of bugs avoided.

@evancz evancz closed this Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment