/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Graphics.Collage.move implies (y,x) rather than (x,y) #370

Closed
eeue56 opened this Issue Aug 25, 2015 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eeue56 @evancz
@eeue56
Contributor

eeue56 commented Aug 25, 2015

From here

(move (10,10) form) would move form ten pixels up and ten pixels to the
right.

when in actuality the code is right first, then up.

move : (Float,Float) -> Form -> Form
move (x,y) f =
  { f | x <- f.x + x, y <- f.y + y }
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 25, 2015

Member

Good point, hadn't thought to be parallel with it. Can you do a PR swapping the order of up and right in the docs?
Member

evancz commented Aug 25, 2015

Good point, hadn't thought to be parallel with it. Can you do a PR swapping the order of up and right in the docs?

@eeue56 eeue56 referenced this issue Aug 25, 2015

Merged

Reword docs for move to reflect order of args #371

@eeue56

This comment has been minimized.

Show comment
Hide comment
@eeue56

eeue56 Aug 25, 2015

Contributor

Yup - just done in #371.
Contributor

eeue56 commented Aug 25, 2015

Yup - just done in #371.

@evancz evancz closed this in #371 Aug 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment