Suggestion: Change the type of (%) to number -> number -> number

[imeckler]

Is there a compelling reason for (%) to have the current restricted type Int -> Int -> Int? Javascript (%) works as expected for non-integers and I often actually need this operation.

[thSoft]

+1

[thSoft]

+1

[imeckler]

In response to evancz's comment, I don't know about Haskell or SML, but in OCaml the function I have in mind is called mod_float. Do you prefer to make it a separate function instead of just changing to type of (%)?

[imeckler]

In response to evancz's comment, I don't know about Haskell or SML, but in OCaml the function I have in mind is called mod_float. Do you prefer to make it a separate function instead of just changing to type of (%)?

[imeckler]

If you need such a function, here's an elm implementation in the meantime.

modFloat : Float -> Float -> Float
modFloat x m = x - m * toFloat (floor (x/m))

[imeckler]

If you need such a function, here's an elm implementation in the meantime.

modFloat : Float -> Float -> Float
modFloat x m = x - m * toFloat (floor (x/m))

[evancz]

I have reservations about using the number type too aggressively, so I'd currently be more comfortable with a separate function. I'm used to seeing it called fmod in places like C++. How this is handled in Java and C# and F#?

[evancz]

I have reservations about using the number type too aggressively, so I'd currently be more comfortable with a separate function. I'm used to seeing it called fmod in places like C++. How this is handled in Java and C# and F#?

[alexiamcdonald]

@bjz and I ran into this the other day. What's the status of adding an fmod style function to the core library?

This is what we used:

fmod : Float -> Int -> Float
fmod f n =
  let integer = floor f
  in  toFloat (integer % n) + f - toFloat integer

[alexiamcdonald]

@bjz and I ran into this the other day. What's the status of adding an fmod style function to the core library?

This is what we used:

fmod : Float -> Int -> Float
fmod f n =
  let integer = floor f
  in  toFloat (integer % n) + f - toFloat integer

[mus0u]

I would also love to see an fmod function added.

[mus0u]

I would also love to see an fmod function added.

[alexiamcdonald]

I've made a library for this one function! It uses the native (%) operator though, so it would have to have a module review. Do you think it is worth it for a one-function package, or can we get this in the standard library? 😛

[alexiamcdonald]

I've made a library for this one function! It uses the native (%) operator though, so it would have to have a module review. Do you think it is worth it for a one-function package, or can we get this in the standard library? 😛

[JoshuaOSHickman]

Found myself needing this function. Not hard to write, but I was mostly just surprised there wasn't something in Basics for it.

[JoshuaOSHickman]

Found myself needing this function. Not hard to write, but I was mostly just surprised there wasn't something in Basics for it.

[evancz]

Consolidated all the math related stuff into the #721 meta issue. Follow along there!

[evancz]

Consolidated all the math related stuff into the #721 meta issue. Follow along there!

[jvoigtlaender]

A version of this function is now in http://package.elm-lang.org/packages/elm-community/basics-extra/2.3.0/Basics-Extra#fmod (by request elm-community/basics-extra#10).

[jvoigtlaender]

A version of this function is now in http://package.elm-lang.org/packages/elm-community/basics-extra/2.3.0/Basics-Extra#fmod (by request elm-community/basics-extra#10).