Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upKeyboard.meta should be renamed to Keyboard.super #414
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
anicholson
commented
Sep 29, 2015
|
See also: http://askubuntu.com/a/19565 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Sep 29, 2015
Contributor
In contrast, see https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey. This is how it is in Browser/JavaScript land. Elm is not going to change that. So the behavior and documentation of Keyboard.meta is exactly as web devs will expect. Keyboard.super would be an alien concept to them.
|
In contrast, see https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey. This is how it is in Browser/JavaScript land. Elm is not going to change that. So the behavior and documentation of |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Sep 29, 2015
Member
@jvoigtlaender is exactly right about why it is named that way. I think it makes sense to stick with the browser versions of the terminology.
|
@jvoigtlaender is exactly right about why it is named that way. I think it makes sense to stick with the browser versions of the terminology. |
evancz
closed this
Sep 29, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
anicholson
Oct 3, 2015
0_o well there you go. TIL. Thanks for the explanation, @jvoigtlaender , and @evancz for a cool language :)
anicholson
commented
Oct 3, 2015
|
0_o well there you go. TIL. Thanks for the explanation, @jvoigtlaender , and @evancz for a cool language :) |
anicholson commentedSep 29, 2015
The documentation for
Keyboard.metastates thatThat doesn't match the usage I've seen. In my experience, Meta has referred to "Alt" on Windows/Linux and "Option" on Mac, whereas the "Windows"/"Command" key has always been referred to as "Super".