New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard.meta should be renamed to Keyboard.super #414

Closed
anicholson opened this Issue Sep 29, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@anicholson

anicholson commented Sep 29, 2015

The documentation for Keyboard.meta states that

{-| The meta key is the Windows key on Windows and the Command key on Mac.
-}

That doesn't match the usage I've seen. In my experience, Meta has referred to "Alt" on Windows/Linux and "Option" on Mac, whereas the "Windows"/"Command" key has always been referred to as "Super".

@anicholson

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Sep 29, 2015

Contributor

In contrast, see https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey. This is how it is in Browser/JavaScript land. Elm is not going to change that. So the behavior and documentation of Keyboard.meta is exactly as web devs will expect. Keyboard.super would be an alien concept to them.

Contributor

jvoigtlaender commented Sep 29, 2015

In contrast, see https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey. This is how it is in Browser/JavaScript land. Elm is not going to change that. So the behavior and documentation of Keyboard.meta is exactly as web devs will expect. Keyboard.super would be an alien concept to them.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 29, 2015

Member

@jvoigtlaender is exactly right about why it is named that way. I think it makes sense to stick with the browser versions of the terminology.

Member

evancz commented Sep 29, 2015

@jvoigtlaender is exactly right about why it is named that way. I think it makes sense to stick with the browser versions of the terminology.

@evancz evancz closed this Sep 29, 2015

@anicholson

This comment has been minimized.

Show comment
Hide comment
@anicholson

anicholson Oct 3, 2015

0_o well there you go. TIL. Thanks for the explanation, @jvoigtlaender , and @evancz for a cool language :)

anicholson commented Oct 3, 2015

0_o well there you go. TIL. Thanks for the explanation, @jvoigtlaender , and @evancz for a cool language :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment