Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWhy not allow calling `embed` with non-DIV elements? #433
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ethagnawl
Feb 11, 2016
I'd like to +1 @TehShrike's comment. The div requirement seems rather arbitrary.
In my use-case, I'm mounting an Elm app into an existing page which is broken up into sections and would like to mount my app directly into its designated section, without having to insert a nested placeholder div.
ethagnawl
commented
Feb 11, 2016
|
I'd like to +1 @TehShrike's comment. The In my use-case, I'm mounting an Elm app into an existing page which is broken up into |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
May 11, 2016
Member
I don't think it's true anymore. Not sure. Reopen with a SSCCE for 0.17 if it is. Also some motivation for why you want to make a change.
|
I don't think it's true anymore. Not sure. Reopen with a SSCCE for 0.17 if it is. Also some motivation for why you want to make a change. |
TehShrike commentedNov 15, 2015
I would like to embed a module on a non-div element.
Right now, that throws an error: https://github.com/elm-lang/core/blob/master/src/Native/Runtime.js?ts=3#L23
What are the reasons for this? I'm guessing that Elm expects the element to have
display: block- if so, why not just require that, or even add that style manually?