New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not allow calling `embed` with non-DIV elements? #433

Closed
TehShrike opened this Issue Nov 15, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@TehShrike

TehShrike commented Nov 15, 2015

I would like to embed a module on a non-div element.

Right now, that throws an error: https://github.com/elm-lang/core/blob/master/src/Native/Runtime.js?ts=3#L23

What are the reasons for this? I'm guessing that Elm expects the element to have display: block - if so, why not just require that, or even add that style manually?

@ethagnawl

This comment has been minimized.

Show comment
Hide comment
@ethagnawl

ethagnawl Feb 11, 2016

I'd like to +1 @TehShrike's comment. The div requirement seems rather arbitrary.

In my use-case, I'm mounting an Elm app into an existing page which is broken up into sections and would like to mount my app directly into its designated section, without having to insert a nested placeholder div.

ethagnawl commented Feb 11, 2016

I'd like to +1 @TehShrike's comment. The div requirement seems rather arbitrary.

In my use-case, I'm mounting an Elm app into an existing page which is broken up into sections and would like to mount my app directly into its designated section, without having to insert a nested placeholder div.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 11, 2016

Member

I don't think it's true anymore. Not sure. Reopen with a SSCCE for 0.17 if it is. Also some motivation for why you want to make a change.

Member

evancz commented May 11, 2016

I don't think it's true anymore. Not sure. Reopen with a SSCCE for 0.17 if it is. Also some motivation for why you want to make a change.

@evancz evancz closed this May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment