New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear gradient: Incorrect values give javascript runtime error. #434

Closed
ggVGc opened this Issue Nov 15, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@ggVGc

ggVGc commented Nov 15, 2015

If calling linear as such linear (a,b) (c,d) [(0,white), (2, black)], which is obviously incorrect, it results in a runtime error in the javascript output, and nothing being shown or printed on screen. I suggest a crash instead with an indication that the values need to be in the interval [0,1], or some way of preventing a runtime error here, although that seems a bit difficult.

@ggVGc ggVGc changed the title from Linear gradient: Incorrect values give no error in Elm. to Linear gradient: Incorrect values give javascript runtime error. Nov 15, 2015

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 11, 2016

Member

Sorry for such a slow response, been very focused on Elm 0.17 stuff. The Graphics.* modules have moved to evancz/elm-graphics so it makes sense to move this over there. I think this will also make it less likely that issues get lost in the shuffle.

Member

evancz commented May 11, 2016

Sorry for such a slow response, been very focused on Elm 0.17 stuff. The Graphics.* modules have moved to evancz/elm-graphics so it makes sense to move this over there. I think this will also make it less likely that issues get lost in the shuffle.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Aug 16, 2016

Contributor

For anyone encountering this: This now lives as a newly opened issue at evancz/elm-graphics#14, with an SSCCE.

Contributor

jvoigtlaender commented Aug 16, 2016

For anyone encountering this: This now lives as a newly opened issue at evancz/elm-graphics#14, with an SSCCE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment