New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug gives error "newProps is not defined" #437

Closed
sanichi opened this Issue Nov 19, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@sanichi

sanichi commented Nov 19, 2015

I think the variable names props and newProps should be the same in lines 456 and 460 of the function clickable in core/src/Native/Graphics/Input.js:

        var element = wrappedElement._0;
        var props = Utils.update(element.props, { click: onClick });
        return {
            ctor: wrappedElement.ctor,
            _0: {
                props: newProps,
                element: element.element
            }
        };

Comparing with the function before that one (hoverable) it looks like there's a typo on line 456, and it possibly was meant to be:

var newProps = Utils.update(element.props, { click: onClick });
@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Nov 19, 2015

Contributor

@evancz, is this another case of props changes needed, like in the last minute changes earlier today?

Contributor

jvoigtlaender commented Nov 19, 2015

@evancz, is this another case of props changes needed, like in the last minute changes earlier today?

@evancz evancz closed this in 14d4f7f Nov 19, 2015

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Nov 19, 2015

Member

Should be fixed now. Clear out elm-stuff/ and try again.

Member

evancz commented Nov 19, 2015

Should be fixed now. Clear out elm-stuff/ and try again.

@sanichi

This comment has been minimized.

Show comment
Hide comment
@sanichi

sanichi Nov 19, 2015

Thanks a million!

sanichi commented Nov 19, 2015

Thanks a million!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment