New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"up.props not defined" error in elm reactor 0.16 #438

Closed
fredcy opened this Issue Nov 19, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@fredcy
Contributor

fredcy commented Nov 19, 2015

The customButton native code tries to access up.props.width but up.props is not defined. Looks like an intermediate _0 object was introduced between up and the props property.

@fredcy

This comment has been minimized.

Show comment
Hide comment
@fredcy

fredcy Nov 20, 2015

Contributor

@evancz This problem manifests when running elm reactor in 0.16 but looks to me to be a significant problem in core/src/Native/Graphics. Some recent change added a wrapper layer in Element named _0 but there is still code around expecting to access properties like props directly from the element. Case in point is the customButton function mentioned above.

Contributor

fredcy commented Nov 20, 2015

@evancz This problem manifests when running elm reactor in 0.16 but looks to me to be a significant problem in core/src/Native/Graphics. Some recent change added a wrapper layer in Element named _0 but there is still code around expecting to access properties like props directly from the element. Case in point is the customButton function mentioned above.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jan 19, 2016

Contributor

Is this still relevant or was it fixed by elm-lang@09f3dd2?

Contributor

jvoigtlaender commented Jan 19, 2016

Is this still relevant or was it fixed by elm-lang@09f3dd2?

@fredcy

This comment has been minimized.

Show comment
Hide comment
@fredcy

fredcy Jan 19, 2016

Contributor

It was fixed by the latter. I'm closing this now.

Contributor

fredcy commented Jan 19, 2016

It was fixed by the latter. I'm closing this now.

@fredcy fredcy closed this Jan 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment