Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove the Date API #467
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jan 19, 2016
Contributor
@lukewestby, the link you give (https://github.com/lukewestby/elm-date-extra) leads into nothingness. But I agree that given this policy it probably makes more sense to target another package with this feature request than core. Maybe https://github.com/rluiten/elm-date-extra?
|
@lukewestby, the link you give (https://github.com/lukewestby/elm-date-extra) leads into nothingness. But I agree that given this policy it probably makes more sense to target another package with this feature request than |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jan 19, 2016
Contributor
Or maybe https://github.com/rluiten/elm-date-extra does already provide the sought functionality?
|
Or maybe https://github.com/rluiten/elm-date-extra does already provide the sought functionality? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lukewestby
Jan 19, 2016
Member
Ah, sorry! I completely forgot to update this issue. Yes! Robin took over the effort on elm-date-extra, https://github.com/rluiten/elm-date-extra is the "official" unofficial date extensions package. It does not currently provide the suggested functionality.
|
Ah, sorry! I completely forgot to update this issue. Yes! Robin took over the effort on elm-date-extra, https://github.com/rluiten/elm-date-extra is the "official" unofficial date extensions package. It does not currently provide the suggested functionality. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Feb 4, 2016
Contributor
@imeckler, can this be closed here? Take it up in https://github.com/rluiten/elm-date-extra?
|
@imeckler, can this be closed here? Take it up in https://github.com/rluiten/elm-date-extra? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@jvoigtlaender Sounds good |
imeckler commentedDec 26, 2015
I think the
DateAPI would really benefit from a functionsince now the only ways of creating a date are from a string or a
Time.I'm not the best at naming things, so other name suggestions for this function would be much appreciated.
It's a bit (though not entirely) of a separate issue, but it seems a
Dateis actually a calendar date equipped with a time of day. Thus the above function should in an ideal world bewhere
CalendarDateis implemented by{ year : Int, month : Month, day : Int}andTimeOfDayis implemented byTime.