Regex.split modifies the state of the regex

[rgrempel]

Regex.split modifies the state of the regex parameter, because it does not reset the lastIndex property.

This is essentially the same problem that Regex.find had, before the following commit:

jonathanhefner@3fcf583

So, Regex.split essentially needs a similar sort of fix.

[jvoigtlaender]

Can you give an example of an Elm program that is affected by this issue? (Same question for https://github.com/elm-lang/core/issues/483 as well.)

[jvoigtlaender]

Can you give an example of an Elm program that is affected by this issue? (Same question for https://github.com/elm-lang/core/issues/483 as well.)

[rgrempel]

Well, it turns out that I can't -- so I'll close this issue!

[rgrempel]

Well, it turns out that I can't -- so I'll close this issue!

[rgrempel]

Ah, actually I can illustrate the issue, using http://elm-lang.org/try. Here's the problematic example:

import Regex exposing (..)
import Graphics.Element exposing (..)

findComma = regex(",")

main = show
  [ split (AtMost 1) findComma "a,b,c,d,e"
  , split (AtMost 1) findComma "a,b,c,d,e"
  ] 

It produces:

[["a","b,c,d,e"],["b","c,d,e"]]

... where one would expect the same result both times.

[rgrempel]

Ah, actually I can illustrate the issue, using http://elm-lang.org/try. Here's the problematic example:

import Regex exposing (..)
import Graphics.Element exposing (..)

findComma = regex(",")

main = show
  [ split (AtMost 1) findComma "a,b,c,d,e"
  , split (AtMost 1) findComma "a,b,c,d,e"
  ] 

It produces:

[["a","b,c,d,e"],["b","c,d,e"]]

... where one would expect the same result both times.

[evancz]

Consolidated regex stuff in #722. Follow along there!

Seems like this could be a PR though.

[evancz]

Consolidated regex stuff in #722. Follow along there!

Seems like this could be a PR though.