Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upKeyboard should provide an equivalent to the wasd function for non-english layout #512
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Feb 28, 2016
Contributor
Please consider everything that was written here: https://github.com/elm-lang/core/pull/492
|
Please consider everything that was written here: https://github.com/elm-lang/core/pull/492 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Mar 20, 2016
Contributor
@kototama, any further thoughts after reading what I pointed you to?
|
@kototama, any further thoughts after reading what I pointed you to? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kototama
Mar 20, 2016
That's basically what I did before opening this PR. It's not as convenient as it seems.
I can understand the wish to not put too much into core but on the other hand, for this case, core is assuming that most users will have a US layout. The need of users having others layouts is more complicate to implement because not all functions are exposed. It's not very fair.
A library can be close to modification, but it should be open for extension. It would be nicer to have a higher level function that build the equivalent of wasd given different keys mapping / layouts.
kototama
commented
Mar 20, 2016
|
That's basically what I did before opening this PR. It's not as convenient as it seems. I can understand the wish to not put too much into core but on the other hand, for this case, core is assuming that most users will have a US layout. The need of users having others layouts is more complicate to implement because not all functions are exposed. It's not very fair. A library can be close to modification, but it should be open for extension. It would be nicer to have a higher level function that build the equivalent of |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Mar 20, 2016
Contributor
Fair points. I am not making decisions about what goes into core. So you'll have to wait until Evan gets around to considering your issue.
But as pointed out by me in the other thread, a more targetted request (more targetted than "provide an equivalent to the wasd function for non-english layout") may make more sense. Propose specifically to resurrect the directions function from core version 1.0.0? Or just to expose the toXY function? (Exposing dropMap makes no sense from an API perspective.)
|
Fair points. I am not making decisions about what goes into But as pointed out by me in the other thread, a more targetted request (more targetted than "provide an equivalent to the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kototama
commented
Mar 20, 2016
|
I'll have a second look when I have more time. Thank you. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Jul 6, 2016
Contributor
This issue would now belong over at https://github.com/elm-lang/keyboard.
|
This issue would now belong over at https://github.com/elm-lang/keyboard. |
kototama commentedFeb 27, 2016
The keyboard module should provide a function to build the equivalent of the
wasdfunction, or at least exposedropmaxandtoXY, to allow the clients to have the function for non-english layout.