New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard should provide an equivalent to the wasd function for non-english layout #512

Closed
kototama opened this Issue Feb 27, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@kototama

kototama commented Feb 27, 2016

The keyboard module should provide a function to build the equivalent of the wasd function, or at least expose dropmax and toXY, to allow the clients to have the function for non-english layout.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Feb 28, 2016

Contributor

Please consider everything that was written here: https://github.com/elm-lang/core/pull/492

Contributor

jvoigtlaender commented Feb 28, 2016

Please consider everything that was written here: https://github.com/elm-lang/core/pull/492

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Mar 20, 2016

Contributor

@kototama, any further thoughts after reading what I pointed you to?

Contributor

jvoigtlaender commented Mar 20, 2016

@kototama, any further thoughts after reading what I pointed you to?

@kototama

This comment has been minimized.

Show comment
Hide comment
@kototama

kototama Mar 20, 2016

That's basically what I did before opening this PR. It's not as convenient as it seems.

I can understand the wish to not put too much into core but on the other hand, for this case, core is assuming that most users will have a US layout. The need of users having others layouts is more complicate to implement because not all functions are exposed. It's not very fair.

A library can be close to modification, but it should be open for extension. It would be nicer to have a higher level function that build the equivalent of wasd given different keys mapping / layouts.

kototama commented Mar 20, 2016

That's basically what I did before opening this PR. It's not as convenient as it seems.

I can understand the wish to not put too much into core but on the other hand, for this case, core is assuming that most users will have a US layout. The need of users having others layouts is more complicate to implement because not all functions are exposed. It's not very fair.

A library can be close to modification, but it should be open for extension. It would be nicer to have a higher level function that build the equivalent of wasd given different keys mapping / layouts.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Mar 20, 2016

Contributor

Fair points. I am not making decisions about what goes into core. So you'll have to wait until Evan gets around to considering your issue.

But as pointed out by me in the other thread, a more targetted request (more targetted than "provide an equivalent to the wasd function for non-english layout") may make more sense. Propose specifically to resurrect the directions function from core version 1.0.0? Or just to expose the toXY function? (Exposing dropMap makes no sense from an API perspective.)

Contributor

jvoigtlaender commented Mar 20, 2016

Fair points. I am not making decisions about what goes into core. So you'll have to wait until Evan gets around to considering your issue.

But as pointed out by me in the other thread, a more targetted request (more targetted than "provide an equivalent to the wasd function for non-english layout") may make more sense. Propose specifically to resurrect the directions function from core version 1.0.0? Or just to expose the toXY function? (Exposing dropMap makes no sense from an API perspective.)

@kototama

This comment has been minimized.

Show comment
Hide comment
@kototama

kototama Mar 20, 2016

I'll have a second look when I have more time. Thank you.

kototama commented Mar 20, 2016

I'll have a second look when I have more time. Thank you.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jul 6, 2016

Contributor

This issue would now belong over at https://github.com/elm-lang/keyboard.

Contributor

jvoigtlaender commented Jul 6, 2016

This issue would now belong over at https://github.com/elm-lang/keyboard.

@evancz evancz closed this Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment