Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUsing two Keyboard signals, the second did not work #520
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Mar 14, 2016
Contributor
Isn't the last sentence of the documentation of http://package.elm-lang.org/packages/elm-lang/core/3.0.0/Signal#merge clear enough on this?
|
Isn't the last sentence of the documentation of http://package.elm-lang.org/packages/elm-lang/core/3.0.0/Signal#merge clear enough on this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jessitron
Mar 14, 2016
Thanks for the references.
It is not clear that keysDown and ctrl are the same signal underneath. (I can see it in the source, but not the docs)
jessitron
commented
Mar 14, 2016
|
Thanks for the references. It is not clear that keysDown and ctrl are the same signal underneath. (I can see it in the source, but not the docs) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Mar 14, 2016
Contributor
Yes, it's nowhere specified in the docs which signals come from the same origin.
Do you have a proposal for how to do this? For the Keyboard module or in general?
|
Yes, it's nowhere specified in the docs which signals come from the same origin. Do you have a proposal for how to do this? For the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
No reply from @jessitron. Am closing this. |
jvoigtlaender
closed this
Mar 20, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jessitron
Mar 21, 2016
Sorry I missed this notification.
It's OK to close it, it isn't specifically a bug, but it would be nice if
there was a comment at the top of the Keyboard file indicating which
signals are mutually exclusive.
On Sun, Mar 20, 2016 at 6:43 PM, Janis Voigtländer <notifications@github.com
wrote:
Closed #520 https://github.com/elm-lang/core/issues/520.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/issues/520#event-596369962
jessitron
commented
Mar 21, 2016
|
Sorry I missed this notification. On Sun, Mar 20, 2016 at 6:43 PM, Janis Voigtländer <notifications@github.com
|
jvoigtlaender
referenced this issue
Mar 21, 2016
Closed
Clarify joint behavior of Keyboard signals #532
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Mar 21, 2016
Contributor
@jessitron, I try to address this in https://github.com/elm-lang/core/pull/532 now.
|
@jessitron, I try to address this in https://github.com/elm-lang/core/pull/532 now. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jessitron
commented
Mar 22, 2016
|
\o/ |
jessitron commentedMar 14, 2016
Using both Keyboard.keysDown and Keyboard.ctrl, mapping then merging them to get my input signal: the second one (Keyboard.ctrl) did not fire. Replacing Keyboard.keysDown with a constant signal caused Keyboard.ctrl to work.
Is this expected? Can only one of the signals that internally feeds off keysDown be used?
If so, documentation would be nice,
I'm in Safari on a Mac.