New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using two Keyboard signals, the second did not work #520

Closed
jessitron opened this Issue Mar 14, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@jessitron

jessitron commented Mar 14, 2016

Using both Keyboard.keysDown and Keyboard.ctrl, mapping then merging them to get my input signal: the second one (Keyboard.ctrl) did not fire. Replacing Keyboard.keysDown with a constant signal caused Keyboard.ctrl to work.

Is this expected? Can only one of the signals that internally feeds off keysDown be used?
If so, documentation would be nice,

I'm in Safari on a Mac.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Mar 14, 2016

Contributor

Isn't the last sentence of the documentation of http://package.elm-lang.org/packages/elm-lang/core/3.0.0/Signal#merge clear enough on this?

Contributor

jvoigtlaender commented Mar 14, 2016

Isn't the last sentence of the documentation of http://package.elm-lang.org/packages/elm-lang/core/3.0.0/Signal#merge clear enough on this?

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jessitron

This comment has been minimized.

Show comment
Hide comment
@jessitron

jessitron Mar 14, 2016

Thanks for the references.

It is not clear that keysDown and ctrl are the same signal underneath. (I can see it in the source, but not the docs)

jessitron commented Mar 14, 2016

Thanks for the references.

It is not clear that keysDown and ctrl are the same signal underneath. (I can see it in the source, but not the docs)

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Mar 14, 2016

Contributor

Yes, it's nowhere specified in the docs which signals come from the same origin.

Do you have a proposal for how to do this? For the Keyboard module or in general?

Contributor

jvoigtlaender commented Mar 14, 2016

Yes, it's nowhere specified in the docs which signals come from the same origin.

Do you have a proposal for how to do this? For the Keyboard module or in general?

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Mar 20, 2016

Contributor

No reply from @jessitron. Am closing this.

Contributor

jvoigtlaender commented Mar 20, 2016

No reply from @jessitron. Am closing this.

@jessitron

This comment has been minimized.

Show comment
Hide comment
@jessitron

jessitron Mar 21, 2016

Sorry I missed this notification.
It's OK to close it, it isn't specifically a bug, but it would be nice if
there was a comment at the top of the Keyboard file indicating which
signals are mutually exclusive.

On Sun, Mar 20, 2016 at 6:43 PM, Janis Voigtländer <notifications@github.com

wrote:

Closed #520 https://github.com/elm-lang/core/issues/520.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/issues/520#event-596369962

jessitron commented Mar 21, 2016

Sorry I missed this notification.
It's OK to close it, it isn't specifically a bug, but it would be nice if
there was a comment at the top of the Keyboard file indicating which
signals are mutually exclusive.

On Sun, Mar 20, 2016 at 6:43 PM, Janis Voigtländer <notifications@github.com

wrote:

Closed #520 https://github.com/elm-lang/core/issues/520.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/elm-lang/core/issues/520#event-596369962

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender
Contributor

jvoigtlaender commented Mar 21, 2016

@jessitron, I try to address this in https://github.com/elm-lang/core/pull/532 now.

@jessitron

This comment has been minimized.

Show comment
Hide comment
@jessitron

jessitron commented Mar 22, 2016

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment