Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPossible dead code in Native.Graphics.Element #540
Comments
halfzebra
referenced this issue
Mar 30, 2016
Closed
Removed dead code from Native/Graphics/Element #544
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Created a pilot PR for this issue #544 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
May 11, 2016
Member
Sorry for the slow reply. It has been busy times. All the Graphics.* modules have moved to evancz/elm-graphics so it makes sense to retarget stuff like this.
I was not immediately confident that it was doing nothing. I'd want stronger assurances before making this change. Whoo JavaScript! ;)
|
Sorry for the slow reply. It has been busy times. All the I was not immediately confident that it was doing nothing. I'd want stronger assurances before making this change. Whoo JavaScript! ;) |
rgrempel commentedMar 27, 2016
There appears to be a little bit of dead code here, in version 3.0.0.
https://github.com/elm-lang/core/blob/3.0.0/src/Native/Graphics/Element.js#L504-L508
At least, I don't think it is doing anything -- it's always possible that I'm missing something.
Note that it does not cause any tangible problems, as far as I can tell. So, it would not be a high priority to fix -- just thought I'd record it in case it was useful at an appropriate moment.