toString isn't type safe for Html

[emptyflash]

Originally posted at elm/compiler#1347

I get a runtime error from this code

viewBoard : Address Action -> Board -> Html

view : Address Action -> Model -> Html
view address model =
  div
    [ containerStyle ]
    [ viewBoard address model.board
        |> toString
        |> text
    ]

The error given is Uncaught TypeError: Cannot use 'in' operator to search for 'ctor' in null coming from the generated toString function. I think this has something to do with the fact that typeof for null returns "object", but this line else if (type === 'object' && 'ctor' in v) throws an error if v is null.

Here's my generated code:

var view = F2(function (address,model) {
    return A2($Html.div,_U.list([containerStyle]),_U.list([$Html.text($Basics.toString(A2(viewBoard,address,model.board)))]));
});

I don't actually want to convert the Html to a string, the Elm code above was a mistake, but it seems like maybe the compiler could have caught or handled it.

If someone could point me in the right direction, I would be more than willing to fix this.

[jvoigtlaender]

As I explained in the other repository, there is already an issue open on this in this repository here. It makes zero sense to have another issue open. So I'm closing this.

[jvoigtlaender]

As I explained in the other repository, there is already an issue open on this in this repository here. It makes zero sense to have another issue open. So I'm closing this.

[jvoigtlaender]

The relevant issue is https://github.com/elm-lang/core/issues/488, and there is already a candidate PR about fixing it (https://github.com/elm-lang/core/pull/183).

[jvoigtlaender]

The relevant issue is https://github.com/elm-lang/core/issues/488, and there is already a candidate PR about fixing it (https://github.com/elm-lang/core/pull/183).

[emptyflash]

Ah, my bad, I misunderstood the corresponding issue part. Thanks for the references!

[emptyflash]

Ah, my bad, I misunderstood the corresponding issue part. Thanks for the references!