/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 `rem` 0 is NaN #563

Closed
miikka opened this Issue Apr 19, 2016 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@miikka @jvoigtlaender
@miikka

miikka commented Apr 19, 2016

Just noticed this (with elm repl 0.16.0 - not sure if that's the relevant version information):

> 1 `rem` 0
NaN : Int

Issue elm/compiler#262 seems to say that NaN shouldn't be an Int, so I assume this is a bug. Relevant source.

(I originally opened this issue as elm/compiler#1338 but moved it here as per @mgold's suggestion.)

@miikka miikka referenced this issue Apr 19, 2016

Closed

1 `rem` 0 is NaN #1338

@jvoigtlaender jvoigtlaender referenced this issue Apr 19, 2016

Closed

Make `rem a 0` throw an error (just like `mod a 0` resp. `a % 0` does) #564

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Apr 19, 2016

Contributor

Fixing this in https://github.com/elm-lang/core/pull/576.
Contributor

jvoigtlaender commented Apr 19, 2016 •
edited
Edited 1 time
  • @jvoigtlaender jvoigtlaender edited Apr 28, 2016 (most recent)

Fixing this in https://github.com/elm-lang/core/pull/576.

@jvoigtlaender jvoigtlaender referenced this issue Apr 28, 2016

Closed

Make `rem a 0` throw an error (just like `mod a 0` resp. `a % 0` does) #576

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender May 10, 2016

Contributor

I've replaced #576 by the more comprehensive #590.

I'm closing this here, since I think any discussion of this should take the larger picture of other division operators in Elm into account, see #590.
Contributor

jvoigtlaender commented May 10, 2016

I've replaced #576 by the more comprehensive #590.

I'm closing this here, since I think any discussion of this should take the larger picture of other division operators in Elm into account, see #590.

@jvoigtlaender jvoigtlaender closed this May 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment