List.take throws "Maximum call stack size exceeded" with large numbers

[tgecho]

This happens if you try to take with an n greater than about 5707 and the list you're taking from has at least that many items. This did not happen in v0.16.

In elm-repl:

> List.take 5707 [0..10000]
RangeError: Maximum call stack size exceeded

[jvoigtlaender]

This version would not have that stack explosion issue:

take : Int -> List a -> List a
take n list =
  List.reverse (takeHelper n list [])

takeHelper : Int -> List a -> List a -> List a
takeHelper n list acc =
  if n <= 0 then
    acc

  else
    case list of
      [] ->
        acc

      x :: xs ->
        takeHelper (n - 1) xs (x :: acc)

[jvoigtlaender]

This version would not have that stack explosion issue:

take : Int -> List a -> List a
take n list =
  List.reverse (takeHelper n list [])

takeHelper : Int -> List a -> List a -> List a
takeHelper n list acc =
  if n <= 0 then
    acc

  else
    case list of
      [] ->
        acc

      x :: xs ->
        takeHelper (n - 1) xs (x :: acc)

[jvoigtlaender]

Covered by https://github.com/elm-lang/core/pull/668.

[jvoigtlaender]

Covered by https://github.com/elm-lang/core/pull/668.