Outgoing ports do not automatically convert Maybe anymore

[CumpsD]

As of 0.17, outgoing ports do not automatically convert Maybe anymore. According to the docs at http://guide.elm-lang.org/interop/javascript.html#customs-and-border-protection and the behaviour in 0.16 they should be.

For example:

type alias Options =
   { responseType : String
   , rememberLastLogin : Maybe Bool
   , closable : Maybe Bool
   , popup : Maybe Bool
   , sso : Maybe Bool
   , callbackURL : Maybe String
   , authParams: { scope: String }
   }

and later

auth0Options : Options
auth0Options =
  { responseType = "token"
  , callbackURL = Nothing -- "http://localhost:3000"
  , rememberLastLogin = Just True
  , closable = Just False
  , popup = Just False
  , sso = Just True
  , authParams = { scope = "openid" }
  }

results in:

While it should result in a callbackURL of null and a closable of false

[neoeinstein]

Confirmed that the related behavior in 0.16 would have translated the callbackUrl = Nothing to null and the closable = Just False to false.

Format of the outgoing port in this instance:

port auth0showLock : Auth0.Options -> Cmd msg

[neoeinstein]

Confirmed that the related behavior in 0.16 would have translated the callbackUrl = Nothing to null and the closable = Just False to false.

Format of the outgoing port in this instance:

port auth0showLock : Auth0.Options -> Cmd msg

[neoeinstein]

Just did my own review of this, and things seemed to work fine for me. I saw the appropriate generated code:

And the appropriate conversion happening:

Could this possibly be due to Elm not rebuilding a dirty module? You can try deleting elm-stuff/build-artifacts and that should trigger a rebuild of all modules.

[neoeinstein]

Just did my own review of this, and things seemed to work fine for me. I saw the appropriate generated code:

And the appropriate conversion happening:

Could this possibly be due to Elm not rebuilding a dirty module? You can try deleting elm-stuff/build-artifacts and that should trigger a rebuild of all modules.

[CumpsD]

I removed it all, and tried again but still have the same problem.

This is the code which causes it: https://github.com/exira/admin

git clone https://github.com/exira/admin.git
npm install
elm-package install -y
gulp

[CumpsD]

I removed it all, and tried again but still have the same problem.

This is the code which causes it: https://github.com/exira/admin

git clone https://github.com/exira/admin.git
npm install
elm-package install -y
gulp

[evancz]

Can you open this on the elm-compiler repo instead? This is not related to core libraries.

Also, is there any way you can get an http://sscce.org/ that does not require cloning a ton of files? Getting it down to something small makes it much easier to resolve, and it'll be more clear why @neoeinstein could not replicate the problem.

[evancz]

Can you open this on the elm-compiler repo instead? This is not related to core libraries.

Also, is there any way you can get an http://sscce.org/ that does not require cloning a ton of files? Getting it down to something small makes it much easier to resolve, and it'll be more clear why @neoeinstein could not replicate the problem.

[evancz]

Given the state of this, I think it makes sense to close and wait for another report of the issue on elm-compiler.

[evancz]

Given the state of this, I think it makes sense to close and wait for another report of the issue on elm-compiler.