/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String.reverse doesn't handle unicode characters properly #625

Closed
eoftedal opened this Issue May 26, 2016 · 5 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eoftedal @evancz
@eoftedal

eoftedal commented May 26, 2016

Examples from repl:

With combining unicode character (U+0300), the combining character becomes attached to the wrong character:

> String.reverse "màn"
"ǹam" : String

With astral symbols (four byte UTF-8 character: U+1D306) it seems the surrogate pair is reversed:

> String.reverse "𝌆"
"��" : String
@eoftedal

This comment has been minimized.

Show comment
Hide comment
@eoftedal

eoftedal May 26, 2016 

> String.length "𝌆"
2 : Int

https://github.com/elm-lang/core/pull/626

eoftedal commented May 26, 2016 •
edited
Edited 1 time
  • @eoftedal eoftedal edited May 26, 2016 (most recent) 

> String.length "𝌆"
2 : Int

https://github.com/elm-lang/core/pull/626
@eoftedal

This comment has been minimized.

Show comment
Hide comment
@eoftedal

eoftedal May 26, 2016

Some inspiration:
https://mathiasbynens.be/notes/javascript-unicode
https://github.com/mathiasbynens/esrever/blob/master/esrever.js

eoftedal commented May 26, 2016 •
edited
Edited 1 time
  • @eoftedal eoftedal edited May 26, 2016 (most recent)

Some inspiration:
https://mathiasbynens.be/notes/javascript-unicode
https://github.com/mathiasbynens/esrever/blob/master/esrever.js
@eoftedal

This comment has been minimized.

Show comment
Hide comment
@eoftedal

eoftedal May 26, 2016

Pull request for reversing: https://github.com/elm-lang/core/pull/627

eoftedal commented May 26, 2016

Pull request for reversing: https://github.com/elm-lang/core/pull/627

This was referenced May 26, 2016

Closed
Closed

@ckoster22 ckoster22 referenced this issue Jul 31, 2016

Closed

String.reverse works incorrectly for strings with combining diaeresis #676

@evancz evancz referenced this issue Sep 23, 2016

Closed

String and Char #725

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 23, 2016

Member

Tracking in #725
Member

evancz commented Sep 23, 2016 •
edited
Edited 1 time
  • @evancz evancz edited Sep 23, 2016 (most recent)

Tracking in #725

@evancz evancz closed this Sep 23, 2016

@eoftedal

This comment has been minimized.

Show comment
Hide comment
@eoftedal

eoftedal Nov 4, 2016

@evancz In #725 you should also include the count issue from my second comment in this thread

eoftedal commented Nov 4, 2016

@evancz In #725 you should also include the count issue from my second comment in this thread

evancz added a commit that referenced this issue Mar 25, 2017

@evancz
Fix #625, String.reverse works outside of BMP 
Based on https://jsperf.com/utf16-string-reverse/1 it seems like the
new code is faster in Chrome and Safari, and the same in Opera.
8ca9c38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment